Fix GCMShortBuffer test #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geedo0
previously approved these changes
Mar 8, 2024
SalusaSecondus
force-pushed
the
gcmshortbuffer
branch
from
0f27122 to
445f831
Compare
|
Change was simply rebasing my changes. |
|
Closing and reopening to trigger the run again. The failure doesn't make sense. |
geedo0
approved these changes
Mar 12, 2024
amirhosv
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenJDK test GCMShortBuffer checks to ensure that a
ShortBufferExceptionthrown byCipher.doFinal()does not reset the cipher state. ACCP currently always resets the cipher as part ofCipher.doFinal(). This change causes ACCP to not reset cipher state when the input offsets, lengths, etc. are incorrect. It also includes new unit tests to prevent regression.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.