Github issue #359 #361
Merged
Github issue #359 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geedo0
reviewed
Feb 7, 2024
| @@ -669,6 +669,15 @@ add_custom_target(check-junit-AesGcmEager | |||
|
|
|||
| DEPENDS accp-jar tests-jar) | |||
|
|
|||
| add_custom_target(check-junit-DifferentTempDir | |||
There was a problem hiding this comment.
Not convinced that this is a high signal test. There's no assertion anywhere that a different tmpdir was actually used. Just that these two tests (also, just 1 is sufficient) succeeded when this property was set. I'm inclined to drop this test target.
There was a problem hiding this comment.
I'll drop it in the next patch.
There was a problem hiding this comment.
Since the PR already has the two approvals, I'll drop this in another PR.
WillChilds-Klein
approved these changes
Feb 20, 2024
alexw91
approved these changes
Feb 20, 2024
WillChilds-Klein
force-pushed
the
tmpdir
branch
from
3df220a to
33a045d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #359
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.