ex rebuild: Support override-replace-query
#3372
Conversation
I just changed a single use as a demo, but if we decide to merge this I can do more of them. (I want to avoid a conflict fest though) This will make it easier to migrate fields between the two structs. Now, I think what we *really* want here is to flip everything around here so that we have `DeriveTreefile` and `ComposeTreefile` that include the base, and deref to that. But that would be a much larger churn. The status quo means we can't implement `Deref` to the derive.
We don't support e.g. `override-remove` there...yet.
The `non` part looks like a nonsequitur.
I want to use this in `ex rebuild` to replace packages in the container.
|
Skipping CI for Draft Pull Request. |
|
/test all |
| HyNevra nevra = NULL; | ||
| hy_autoquery HyQuery query = | ||
| hy_subject_get_best_solution(subject, sack, NULL, &nevra, FALSE, TRUE, TRUE, TRUE, FALSE); |
There was a problem hiding this comment.
Hmm, instead of this, I think we should be querying strictly by package name. repo-packages does it this way because it wants to provide the same semantics as packages (which supports e.g. provides and filepaths). But for overrides I think we can be stricter and require the exact package name to override from the base.
So then from the query we'll be getting specific NEVRAs we can add to replaced_nevras as usual.
|
@cgwalters: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Correct. I'm working on that now. I really wanted to have this work for the client-side too (i.e. basically implement what we landed on in #1265), but I'd like to rework the origin and treefile manipulations first. |
|
OK, closing this. |
More work towards #3364
treefile: Also error if derive is nonempty for client side
We don't support e.g.
override-removethere...yet.treefile: Fix naming of
assert_empty()The
nonpart looks like a nonsequitur.treefile: Add
override-replace-queryI want to use this in
ex rebuildto replace packages in thecontainer.