-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crypto.c compile/link with OpenSSL 3 #126
base: master
Are you sure you want to change the base?
Conversation
More work's required in order to get the program to compile cleanly with OpenSSL 3. I'll move this PR back to draft mode and fix those issues. |
Is |
Yes, but I want to clean this up so the folks in this project don't have to do it later. |
Sounds good! |
41d0a50
to
7c4876e
Compare
\o/ |
I've confirmed that the newest revision is functionally correct and produces the same values as it did previously -- I also compared the logic in the python hmac module to confirm that it was sane:
|
@emaste can you check and merge this PR? |
@corecode it might be a little while, but I will put it on the list. I presume we'd like @ngie-eign to squash the fixups into one commit? |
Yes, I was planning on doing that. I left them as fixup commits to aid with reviewing. |
- Initialize libssl using non-deprecated APIs OpenSSL 3 deprecated `SSL_library_init` and `SSL_load_error_strings` in favor of `OPENSSL_init_ssl`. Use `OPENSSL_init_ssl` when dealing with OpenSSL 1.1 and newer to unbreak the build with OpenSSL 3. - Move MD5 APIs to EVP_MD APIs OpenSSL 3 deprecated all of the `MD5_`* APIs. Move to the equivalent `EVP_MD`* APIs so the code doesn't need to be pinned down to 1.1 compatible APIs and uplifted at a later date. Co-authored-by: Pierre Pronchery <pierre@freebsdfoundation.org> Co-authored-by: Ed Maste <emaste@FreeBSD.org> Signed-off-by: Enji Cooper <yaneurabeya@gmail.com> Sponsored by: The FreeBSD Foundation
OpenSSL 3 deprecated
SSL_library_init
andSSL_load_error_strings
infavor of
OPENSSL_init_ssl
. UseOPENSSL_init_ssl
when dealing withOpenSSL 1.1 and newer to unbreak the build with OpenSSL 3.
OpenSSL 3 deprecated all of the
MD5_
* APIs. Move to the equivalentEVP_MD
* APIs so the code doesn't need to be pinned down to 1.1compatible APIs and uplifted at a later date.
Co-authored-by: Pierre Pronchery pierre@freebsdfoundation.org
Co-authored-by: Ed Maste emaste@FreeBSD.org
Signed-off-by: Enji Cooper yaneurabeya@gmail.com
Sponsored by: The FreeBSD Foundation