Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with info on Macos issue workaround #893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

utherp0
Copy link

@utherp0 utherp0 commented Feb 27, 2025

Summary by Sourcery

Documentation:

  • Add a section to the README with a workaround for a potential SSL certificate verification issue on MacOS.

Copy link
Contributor

sourcery-ai bot commented Feb 27, 2025

Reviewer's Guide by Sourcery

This pull request adds a section to the README.md file to address a potential SSL certificate verification issue encountered on macOS after installing the application. It provides a workaround by instructing users to initialize the certificates in their Python version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a section to the README addressing a potential SSL certificate verification issue on macOS after installation.
  • Added a 'Possible Macos installation issue' section.
  • Included a tip about the SSL certificate verification failure.
  • Provided instructions on how to initialize certificates in the Python version to resolve the issue.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @utherp0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a link to the specific Python version's application folder instead of instructing users to navigate manually.
  • It would be good to include the specific error message that users might encounter to help them identify the issue.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

## Possible Macos installation issue
> [!TIP]
> If you are running on Macos and, post-install, get a message saying [SSL:CERTIFICATE_VERIFY_FAILED] when running your first model, you need to initialiswe the certifcates in your Python Version.
> Open the Folder /Applications/Python 3.x (where x is the version you are running)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (bug_risk): Question about Python path on macOS.

The path /Applications/Python 3.x looks unusual. Should it be /Applications/Python\ 3.x or /Applications/Python 3.x/? Also, not all macOS users will have Python installed there. It might be better to suggest they use the Python installation they used to install ramalam.

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2025

Thanks @utherp0
Please sign your command and fix the spelling mistakes. Also in your Mac installation, you explain which install procedure you did to make this happen, or is this just the Python code putting up a prompt?

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@utherp0
Copy link
Author

utherp0 commented Feb 27, 2025

I ran the curl command as shown in the readme - I did have Python pre-installed (for InstructLab)

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2025

Sorry you still need to squash your commits

git rebase -i origin
git push --force

@utherp0
Copy link
Author

utherp0 commented Feb 27, 2025

Apologies, done.

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2025

@utherp0 Sorry still not done correctly, there should only be one commit.

when in rebase use the s option to squash the two commits and save it.

If it is not signed you can do a

git commit -a --amend -s
git push --force.

@utherp0
Copy link
Author

utherp0 commented Feb 27, 2025

I was being lazy and did the update from within the Git web Ux. Bad move.

ilawson@ilawson1-mac ramalama % git commit -a --amend -s
[main f68cb4c] Merge pull request #888 from containers/fix-bench
Author: Daniel J Walsh dwalsh@redhat.com
Date: Wed Feb 26 22:38:05 2025 -0500
ilawson@ilawson1-mac ramalama % git push --force
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 12 threads
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 467 bytes | 467.00 KiB/s, done.
Total 3 (delta 2), reused 1 (delta 1), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To https://github.com/utherp0/ramalama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants