-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with info on Macos issue workaround #893
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds a section to the README.md file to address a potential SSL certificate verification issue encountered on macOS after installing the application. It provides a workaround by instructing users to initialize the certificates in their Python version. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @utherp0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a link to the specific Python version's application folder instead of instructing users to navigate manually.
- It would be good to include the specific error message that users might encounter to help them identify the issue.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
## Possible Macos installation issue | ||
> [!TIP] | ||
> If you are running on Macos and, post-install, get a message saying [SSL:CERTIFICATE_VERIFY_FAILED] when running your first model, you need to initialiswe the certifcates in your Python Version. | ||
> Open the Folder /Applications/Python 3.x (where x is the version you are running) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (bug_risk): Question about Python path on macOS.
The path /Applications/Python 3.x
looks unusual. Should it be /Applications/Python\ 3.x
or /Applications/Python 3.x/
? Also, not all macOS users will have Python installed there. It might be better to suggest they use the Python installation they used to install ramalam.
Thanks @utherp0 |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
I ran the curl command as shown in the readme - I did have Python pre-installed (for InstructLab) |
Sorry you still need to squash your commits git rebase -i origin |
Apologies, done. |
@utherp0 Sorry still not done correctly, there should only be one commit. when in rebase use the If it is not signed you can do a git commit -a --amend -s |
I was being lazy and did the update from within the Git web Ux. Bad move. ilawson@ilawson1-mac ramalama % git commit -a --amend -s
|
Summary by Sourcery
Documentation: