Implement container.update() #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
inknos
force-pushed
the
implement-update-healthcheck
branch
from
1e31f57 to
a089e2b
Compare
inknos
changed the title
inknos
force-pushed
the
implement-update-healthcheck
branch
4 times, most recently
from
0ad0dce to
eea8603
Compare
|
note for myself of tomorrow. fedora 40 and 41 are failing because podman-5.4.0 is not there (check tmt-verbose.log). the ci needs pull podman from podman-next copr in order to test against latest upstream fixes. |
inknos
force-pushed
the
implement-update-healthcheck
branch
6 times, most recently
from
bf80d76 to
63e62c4
Compare
Introduce container.update() api implementation. The options supported
are a direct port to GO's structures, therefore, some of the options
like blkio, need to follow a specific syntax and have to use
dictionaries with GO case style.
See for example blockio = {
"leafWeight": 0
"throttleReadBpsDevice": [{
"major": 0,
"minor": 0,
"rate": 0
}], ...
Other common options, like health_cmd, health_interval,... follow pythonic
implementations and python-like type calls.
Fixes: https://issues.redhat.com/browse/RUN-2427
Signed-off-by: Nicola Sella <nsella@redhat.com>
Looks like tests for all python require more time to run. This can be improved in the future by splitting each python run in a separate test, and, therefore, be run in parallel Signed-off-by: Nicola Sella <nsella@redhat.com>
inknos
force-pushed
the
implement-update-healthcheck
branch
from
63e62c4 to
0cd044e
Compare
Signed-off-by: Nicola Sella <nsella@redhat.com>
inknos
force-pushed
the
implement-update-healthcheck
branch
from
0cd044e to
7beb75b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.