Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add **kwargs to Network.connect call #507

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Feb 3, 2025

This and other methods don't pass **kwargs to requests
and therefore it is not possible to enable the compatible
endpoint.

This and other methods don't pass **kwargs to requests
and therefore it is not possible to enable the compatible
endpoint.

Fixes: https://issues.redhat.com/browse/RHEL-70162

Signed-off-by: Nicola Sella <nsella@redhat.com>
@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
@inknos inknos changed the title Add kwargs to Network.connect call to enable compatible keyword Add **kwargs to Network.connect call Feb 3, 2025
Copy link
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Feb 4, 2025

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, jwhonce, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 74e94ab into containers:main Feb 4, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants