Port to thiserror, drop get_manifest() API
#16
Conversation
cgwalters
force-pushed
the
use-thiserror
branch
from
04942b4 to
67b7e85
Compare
cgwalters
force-pushed
the
use-thiserror
branch
from
67b7e85 to
2f149b4
Compare
It was requested that we use `thiserror` as we're a library. I dropped the `read_manifest` API as I don't think people should use it in general and it would have required its own dedicated error type. Closes: #15 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
use-thiserror
branch
from
2f149b4 to
855b3be
Compare
|
Thanks for addressing this so quickly! |
No problem; let me know if you're interested in being a reviewer/maintainer here. Looking forward to more collaboration! |
|
I'm definitely interested in contributing to this project, especially since I'm in the process of making some changes to PuzzleFS to be more in line with the OCI spec and this crate comes in handy. I would love to become a maintainer! |
Great, invite sent! Once accepted you should have the ability to official mark this PR as reviewed which should merge it. Most repositories in this organization have a "1 review required" rule. |
|
Thanks! Now how do I make a new release? |
That gets into a whole thing around access to crates.io which...hmm is just me right now, that's busted. Conceptually what we should probably do is clean up and centralize this stuff with https://github.com/containers/oci-spec-rs/ too (which recently gained more reviewers too). There's some plumbing to do here, I think we could make a dedicated team in this org, and also ideally automate releases to crates.io from an action or so... (A giant problem with crates.io is the default model encourages publishing from a user's workstation and doesn't even require a public git repository etc.) Anyways for now I did a new release https://crates.io/crates/ocidir/0.3.0 |
Same motivation as containers/ocidir-rs#16 Originally I split this out as a "quick library" and using anyhow was convenient, but since we're bumping semver let's port to thiserror. Signed-off-by: Colin Walters <walters@verbum.org>
It was requested that we use
thiserroras we're a library.I dropped the
read_manifestAPI as I don't think people should use it in general and it would have required its own dedicated error type.Closes: #15