Use relationships to assign and access associated objects #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
suggested changes
Apr 29, 2020
|
@mprahl Hi, thanks for review. All comments should be addressed. PTAL. |
|
@tkdchen it seems like in the last push, you made some changes in the last commit that should have been in the commit before that. Could you please try to clean up the commits? |
|
@mprahl Hi, the commits are cleaned up. Please review again. |
|
Hi @mprahl, I learned you've been busy recently. When you have time, could you please review this pr again? Thanks for your time. |
@tkdchen sorry about the confusion but I'm waiting on you addressing this comment: |
|
@mprahl PTAL :) |
Signed-off-by: Chenxiong Qi <cqi@redhat.com>
This change will save two SQL queries in Request.to_json to convert dependencies to JSON data. Signed-off-by: Chenxiong Qi <cqi@redhat.com>
Signed-off-by: Chenxiong Qi <cqi@redhat.com>
Signed-off-by: Chenxiong Qi <cqi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chenxiong Qi cqi@redhat.com
Relative to #116