-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding modelscope #29210
base: main
Are you sure you want to change the base?
Adding modelscope #29210
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/modelscope/recipe.yaml:
For recipes/modelscope/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13426729689. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/modelscope/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13426864968. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/modelscope/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13429216966. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python This is ready for review. It's ... a thing. I'm both embarrassed and proud of it. This package is nuts because of the massive number of seemingly optional dependencies but it works for nearly more than half of the use case from Conda now (and probably the most useful use cases) and probably largely works close to as well as it does straight from pypi without installing extra deps from a mysterious Chinese hosted index of binary wheels without much details on where they come from. This package is stupid popular on pypi and most people confine their usages to just a few paths that this version supports but it's an omnibus do everything system |
This one needs someone proficient with the new recipe format for a proper review. |
@conda-forge/help-python |
This is a funny omnibus package. It has more optional dependencies than I have seen in a package. It's pretty popular but it's also a mess on some of the bits.
Some features depend on binary-only provided wheels on some random bucket hosted in China (those I can't install for you if you rely on them), and some of the extra dependencies listed just don't exist anywhere I can find except for maybe on old blog posts.
But overall, outside not having some of the optional deps in conda-forge it's largely just as functional as it is as if you installed it from pypi. I'm guessing folks just use the parts that work for them if they can satisfy the deps those models need on their own.
I largely tried to make meta-packages that install most of the deps in each major category like science, multi-model, audio, etc. The computer vision extra from Pypi just uses way too many mysterious deps that even if I wanted to get most into conda-forge, there isn't an authoritative source.
I'm sure a lot of folks will use modelscope.hub and other high-level utilities.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).