Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close out migration for svt_av1300 #7053

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to close out the migration for svt_av1300.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13450952106 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner February 21, 2025 06:10
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 59080b9 into conda-forge:main Feb 21, 2025
3 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-svt_av1300-0-1_h3ade56 branch February 21, 2025 08:34
@hmaarrfk
Copy link
Contributor

Can we revert this? the only 2 packages that use svt-av1 MUST depend on the older version.

@h-vetinari
Copy link
Member

Can we revert this? the only 2 packages that use svt-av1 MUST depend on the older version.

👍

This ultimately boils down to the bot using "PRs opened" rather than "PRs merged" as it's main progress meter, which I think is misleading, both on the status page, as well as for the pinning in cases like this (because the bot sees "all PRs opened, so I can close the migration", even though 0 PRs were merged yet). Not sure why it was designed like this, perhaps @beckermr can chime in.

@hmaarrfk
Copy link
Contributor

i guess its fine, libavif has a patch we could backport, and ffmpeg will likely follow shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants