-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added demo for inspect request in xeus-cpp-lite-demo.ipynb #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Shall Merge after #258 goes in !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That needs to become a part of the previous PR, not a separate one.
Sorry It was me who asked him to make 2 separate PRs as I think they are discrete changes and not really dependent on each other. What I wanted actually is 1 commit for the change and 1 commit for the notebook update. @kr-2003 could you move these changes on your previous PR. We can then move that in |
Changes and the tests should go in the same commit to make sure we have a clear history describing the change and what it was intended to address/fix. |
Perfect, yes ! |
Done 👍 |
Description
Since, #229(Inspect request fails on xeus-cpp-lite) is resolved by #258, I have added the demo for inspect request in
/notebook/xeus-cpp-lite-demo.ipynb
.