Change to core modules #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
anutosh491
reviewed
Jan 14, 2025
| @@ -274,7 +274,7 @@ jobs: | |||
| run: | | |||
| micromamba create -n xeus-lite-host jupyterlite-core | |||
| micromamba activate xeus-lite-host | |||
| python -m pip install jupyterlite-xeus | |||
| python -m pip install jupyterlite-xeus jupyterlite-core jupyterlab | |||
There was a problem hiding this comment.
Maybe playing around with the the deploy pages is fine here but as I said on other Prs I would like to keep consistency in the CI and the readme as to how we come up with any xeus-XX-lite kernel for atleast as of now.
It only makes it easier for jupyterlite maintainers to work with xeus-cpp-lite.
|
Closing in favour of #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
A better alternative to the jupyter_server module we use is to use what the main jupyter lite demo has as core modules https://github.com/jupyterlite/demo/blob/0cddee229c47161aadc17e836ca0b78f991a7908/requirements.txt#L2
Fixes # (issue)
Type of change
Please tick all options which are relevant.