Add jupyter lite contents flag instructions #212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
|
@anutosh491 can you review this PR? |
README.md
Outdated
| @@ -101,8 +101,8 @@ To build Jupyter Lite with this kernel without creating a website you can execut | |||
| ```bash | |||
| micromamba create -n xeus-lite-host jupyterlite-core | |||
| micromamba activate xeus-lite-host | |||
| python -m pip install jupyterlite-xeus | |||
| jupyter lite build --XeusAddon.prefix=$PREFIX | |||
| python -m pip install jupyterlite-xeus jupyter_server | |||
There was a problem hiding this comment.
Why add jupyter_server here ? Does it solve a warning or something ?
There was a problem hiding this comment.
Ahh actually I got it. This is due to jupyterlite/jupyterlite#1402
There was a problem hiding this comment.
Wait a better way to get jupyter_server is through micromamba
use
micromamba create -n xeus-lite-host jupyterlite-core jupyter-server and then let's move this in
|
Left some reviews. Thanks this was needed. once addressed I can move this in ! |
|
Actually I don't think we really need to add contents as a part of building xeus-cpp-lite. Just complicates the process for anyone interested to try out a simple build. We just need to add it as a per of our deployment so that if anyone tries our custom link they know what to do. I'll do this as a part of #221 see the last commit where I have done what is recommended |
|
Closing in favour of #221 |
Description
Please include a summary of changes, motivation and context for this PR.
This PR adds to the documentation the instructions the installing of jupyter_server so that users can add contents to their own deployments. I add an example to add the Jupyter Lite xeus-cpp demo notebook currently deployed for xeus-cpp.
Fixes # (issue)
Type of change
Please tick all options which are relevant.