Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 2025 server to ci #208

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR adds a Windows sever 2025 build to the ci.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (c805027) to head (8262f78).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

@mcbarton mcbarton requested a review from anutosh491 January 10, 2025 20:58
@anutosh491
Copy link
Collaborator

Does windows even work for xeus-cpp ?

#144

@mcbarton
Copy link
Collaborator Author

@anutosh491 Its something I'm working on. It fails as you can't write to standard output and standard error at the moment. Stuff which doesn't require printing still works. I'm hoping to have it fixed sometime this year through CppInterOp. Some work is currently being done in llvm so that everything should work.

@anutosh491
Copy link
Collaborator

It fails as you can't write to standard output and standard error at the moment. Stuff which doesn't require printing still works. I'm hoping to have it fixed sometime this year through CppInterOp.

So what is the CI exactly doing ? Are we testing stuff (the python and the c++ tests) ?
How is this helping us if we can't get xeus-cpp on windows is what I would like to understand ?
I don't see a point populating the CI if its not really beneficial.

@mcbarton
Copy link
Collaborator Author

@anutosh491 Its beneficial since we do python and c++ tests, and this new ci tests that the stuff which does work for Windows server 2022 also works for Windiws 2025 while we wait for the fix to the things which don't currently work.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let's get this in !

@anutosh491 anutosh491 merged commit b4d7277 into compiler-research:main Jan 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants