Improve operator resolution #129
Conversation
|
@vgvassilev, something is failing with cling. Call to |
Maybe |
| void Cppyy::GetClassOperators(Cppyy::TCppScope_t klass, | ||
| const std::string& opname, | ||
| std::vector<TCppScope_t>& operators) { | ||
| if (opname == "operator+") |
There was a problem hiding this comment.
This is something we can fold into an API: const char * GetOperatorKindAsString(Cpp::OperatorKind K);
There was a problem hiding this comment.
For this use case, shouldn't it be Cpp::OperatorKind Cpp::GetOperatorKindFromString(std::string op)?
Also, I believe this should be part of InterOp.
Should I add both? Any thoughts?
There was a problem hiding this comment.
You are right. Let's keep it as is.
`GetMethodTemplate` now also checks for operators methods using `GetClassOperators` `GetGlobalOperator` can now handle templated types
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
| void Cppyy::GetClassOperators(Cppyy::TCppScope_t klass, | ||
| const std::string& opname, | ||
| std::vector<TCppScope_t>& operators) { | ||
| if (opname == "operator+") |
There was a problem hiding this comment.
You are right. Let's keep it as is.
Vipul-Cariappa
force-pushed
the
dev/templated-operators
branch
from
005777f to
14b05fa
Compare
GetMethodTemplatenow also checks for operators methods usingGetClassOperatorsGetGlobalOperatorcan now handle templated typesFixes 2 tests. Along with compiler-research/CppInterOp#509, fixes 3 tests.