feat: Batch support for Basenames and ENS names #2102
Merged
+590
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/feat-batch-ens-basenames
branch
from
780109a to
2da4b4f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dschlabach
reviewed
Mar 11, 2025
| */ | ||
| export const useNames = ( | ||
| { addresses, chain = mainnet }: UseNamesOptions, | ||
| queryOptions?: UseQueryOptions, |
There was a problem hiding this comment.
Ideally, allow dev to pass through any query options that Tanstack supports - will make the hook a lot more useful to support specific use cases
There was a problem hiding this comment.
Will fast follow along with Avatars.
There was a problem hiding this comment.
can you expose gcTime instead of cacheTime so that when you switch to Tanstack query options it won't be a breaking change and we won't have to support both?
dschlabach
previously approved these changes
Mar 11, 2025
alessey
reviewed
Mar 11, 2025
src/identity/types.ts
Outdated
| /** Array of Ethereum addresses to resolve names for */ | ||
| addresses: Address[]; | ||
| /** Optional chain for domain resolution */ | ||
| chain?: typeof mainnet; |
There was a problem hiding this comment.
why wouldn't this be Chain?
There was a problem hiding this comment.
It should be Chain, good catch
alessey
approved these changes
Mar 11, 2025
abcrane123
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added identity resolution components for ENS and Basename support in OnchainKit. This includes:
useNameshook for resolving addresses to ENS/Basename namesSupporting utility function (
getNames) with proper chain fallback logicThe implementation follows the chain fallback pattern where Base-specific resolution is attempted first, then falls back to mainnet ENS resolution when needed
React Query is used for efficient caching and data fetching
Notes to reviewers
How has it been tested?
Without batching. 48 requests:
With batching. 14 requests:
