Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getPriceQuote type #2086

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix: getPriceQuote type #2086

merged 2 commits into from
Mar 5, 2025

Conversation

brendan-defi
Copy link
Contributor

What changed? Why?

  • fix incorrect getPriceQuote type. the api returns an object with priceQuotes plural. the key previously was singular

Notes to reviewers

How has it been tested?
in local playground

API response
image

Send demo
image

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 11:15pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 11:15pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 11:15pm

cpcramer
cpcramer previously approved these changes Mar 5, 2025
@brendan-defi brendan-defi merged commit 43c54f9 into main Mar 5, 2025
16 checks passed
@brendan-defi brendan-defi deleted the fix/getpricequote-types branch March 5, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants