refactor: better TokenBalance #2068
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -141,3 +139,31 @@ function TokenBalanceContent({ | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| function TokenBalanceActionButton({ | |||
There was a problem hiding this comment.
Because this isn't used anywhere outside of TokenBalance I think it'd be better to call this ActionButton or even Action - TokenBalance isn't really adding much
There was a problem hiding this comment.
makes sense, i've renamed
| import { formatUnits } from 'viem'; | ||
| import type { TokenBalanceProps } from '../types'; | ||
|
|
||
| export function TokenBalance({ | ||
| token, | ||
| onClick, | ||
| onActionPress, | ||
| actionText = 'Use max', |
There was a problem hiding this comment.
swap is just "max", should this match?
|
nit: title category should fall under chore, fix, feat, or docs.
|
| /** Hide the token image */ | ||
| showImage: false; |
There was a problem hiding this comment.
nit:
| /** Hide the token image */ | |
| showImage: false; | |
| /** Hide the token image (default: false) */ | |
| showImage: false; |
| /** Hide the action button (default)*/ | ||
| onActionPress?: never; |
There was a problem hiding this comment.
What's the default here? The code comment looks unfinished
| @@ -141,3 +139,31 @@ function TokenBalanceContent({ | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| function ActionButton({ | |||
There was a problem hiding this comment.
Thoughts on putting ActionButton and or TokenBalanceContent in a separate file?
There was a problem hiding this comment.
Seems like TokenBalanceContent should be extracted
What changed? Why?
Notes to reviewers
How has it been tested?