fix(wallet): Export WalletModal to allow custom opening #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@RezaRahemtola is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
gmolki
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added an export of the
WalletModalcomponent to allow opening it from custom connect buttons instead of the generic UI.Spotted during ETH Denver, it was useful for our case as we have multiple login providers, including OnchainKit, and don't want to use the big "Connect" button, but instead our own button that will open the modal.
Using the wagmi connector directly wasn't possible as it only exposes Coinbase Wallet, not the Metamask / Phantom options also provided in this modal
Notes to reviewers
/
How has it been tested?
Straightforward change that shouldn't require testing, but we tested and integrated in our project