Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: WalletIsland Code Quality Fast Follows #1842

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Chore: WalletIsland Code Quality Fast Follows #1842

merged 15 commits into from
Jan 23, 2025

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Jan 19, 2025 •
edited
Loading

What changed? Why?

  • WalletComponents pull address from context by default, only wagmi if intended to be used outside of WalletProvider
  • remove cursor state management, use pure css
  • refactor draggable repositioning, including preventing dragging offscreen
  • remove unused svg
  • extract copyToClipboard to an internal util

Notes to reviewers

How has it been tested?

@vercel Vercel
Copy link

vercel bot commented Jan 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:50pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:50pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:50pm

@brendan-defi brendan-defi requested a review from alessey January 22, 2025 18:17
@brendan-defi brendan-defi merged commit 8d7c5ad into main Jan 23, 2025
16 checks passed
@brendan-defi brendan-defi deleted the chore/wi-qc branch January 23, 2025 00:47
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschlabach dschlabach dschlabach approved these changes

@cpcramer cpcramer cpcramer approved these changes

@abcrane123 abcrane123 Awaiting requested review from abcrane123

@alessey alessey Awaiting requested review from alessey

Assignees
No one assigned
Labels
pkg: core pkg: identity pkg: wallet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendan-defi @alessey @dschlabach @cpcramer