fix: improve typesafety of buildSwapTransaction and getSwapQuote (#…

…1843)
coinbase · Jan 21, 2025 · bbaceed · bbaceed
1 parent cc1ac71
commit bbaceed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/src/core/api/buildSwapTransaction.ts b/src/core/api/buildSwapTransaction.ts
@@ -3,7 +3,6 @@ import { getSwapErrorCode } from '../../swap/utils/getSwapErrorCode';
 import { CDP_GET_SWAP_TRADE } from '../network/definitions/swap';
 import { sendRequest } from '../network/request';
 import type {
-  APIError,
   BuildSwapTransactionParams,
   BuildSwapTransactionResponse,
   SwapAPIParams,
@@ -23,14 +22,13 @@ export async function buildSwapTransaction(
     isAmountInDecimals: false,
   };
 
-  const apiParamsOrError = getAPIParamsForToken({
+  let apiParams = getAPIParamsForToken({
     ...defaultParams,
     ...params,
   });
-  if ((apiParamsOrError as APIError).error) {
-    return apiParamsOrError as APIError;
+  if ('error' in apiParams) {
+    return apiParams;
   }
-  let apiParams = apiParamsOrError as SwapAPIParams;
 
   if (!params.useAggregator) {
     apiParams = {

diff --git a/src/core/api/getSwapQuote.ts b/src/core/api/getSwapQuote.ts
@@ -3,7 +3,6 @@ import { getSwapErrorCode } from '../../swap/utils/getSwapErrorCode';
 import { CDP_GET_SWAP_QUOTE } from '../network/definitions/swap';
 import { sendRequest } from '../network/request';
 import type {
-  APIError,
   GetSwapQuoteParams,
   GetSwapQuoteResponse,
   SwapAPIParams,
@@ -21,14 +20,13 @@ export async function getSwapQuote(
     amountReference: 'from',
     isAmountInDecimals: false,
   };
-  const apiParamsOrError = getAPIParamsForToken({
+  let apiParams = getAPIParamsForToken({
     ...defaultParams,
     ...params,
   });
-  if ((apiParamsOrError as APIError).error) {
-    return apiParamsOrError as APIError;
+  if ('error' in apiParams) {
+    return apiParams;
   }
-  let apiParams = apiParamsOrError as SwapAPIParams;
 
   if (!params.useAggregator) {
     apiParams = {