Skip to content

Commit

Permalink
Merge pull request #197 from GavinHuttley/develop
Browse files Browse the repository at this point in the history
MAINT: code tidy
  • Loading branch information
GavinHuttley authored Feb 27, 2025
2 parents fc9b07c + 671a329 commit 74d8b7a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions src/ensembl_tui/_mysql_core_attr.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ def load_db(db_name: pathlib.Path, table_names: set[str]) -> duckdb.DuckDBPyConn


location_attrs = {
# "coord_names": "coord_system",
"location": "seq_region",
# "meta": "meta",
}
gene_attrs = {
"stableid": "gene",
Expand Down Expand Up @@ -214,7 +212,7 @@ def start(self) -> int:
def stop(self) -> int:
return self.transcript_spans.max()

def to_record(self, columns: tuple[str]) -> tuple:
def to_record(self, columns: tuple[str, ...]) -> tuple:
cds_blob = (
eti_storage.array_to_blob(self.cds_spans)
if self.cds_spans is not None
Expand Down Expand Up @@ -418,6 +416,3 @@ def make_gene_attr(con: duckdb.DuckDBPyConnection) -> duckdb.DuckDBPyConnection:
"""
con.sql(sql)
return con


# the repeat and location related tables are left as is
2 changes: 1 addition & 1 deletion tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def test_check_one_cds_seq(installed):
"CAATTTTTGACCAAGGACTTGAAATTCCCATTGCCTCACAGAGTCCAAAAATCCACCAAG"
"ACTTTCTCCTACAAGAGACCTTCCACTTTCTACTGA"
)
assert str(cds.get_slice()) == expect
assert str(seq) == expect


@pytest.mark.slow
Expand Down

0 comments on commit 74d8b7a

Please sign in to comment.