Fix Properties.store(OutputStream os, String comment)

[gastaldi]

This fixes the store method taking an OutputStream by flushing and closing the writer created to wrap it.

It also introduces ApprovalTests (https://approvaltests.com/) to open a diff window when comparing Strings and File contents

• Fixes Properties#store(OutputStream) doesn't flush the output to the OutputStream #23

[quintesse]

Ok, first, good catch, the docs of Properties.load() does indeed say the stream should be flushed and the underlying stream not closed:

After the entries have been written, the output stream is flushed. The output stream remains open after this method returns.

(closing the writer doesn't close the stream, right? I never know and the docs are not clear)

Second... introducing a new way of testing? Awesome... are you going to migrate the rest of the tests as well? 😁 😛

[gastaldi]

(closing the writer doesn't close the stream, right? I never know and the docs are not clear)

Actually closing the writer flushes and then closes the stream. Maybe we should only flush it instead of closing in a try-with-resources block, I'll check.

Second... introducing a new way of testing? Awesome... are you going to migrate the rest of the tests as well?

I was thinking of leaving the other tests as an exercise for the reader 😉

[quintesse]

I was thinking of leaving the other tests as an exercise for the reader

Hahaha, ok, can I then ask a favor? Could you split the PR in two, one for this fix with a test that follows the same pattern as the other tests and then a new PR showing a single test converted to using that approvals library? I'll then use that PR as a basis for migrating all file-based tests to that system in the future.

[quintesse]

Split into two PRs

[gastaldi]

Created #26 (I'll rebase once this PR is merged)

[quintesse]

Thanks man! :-)