Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#217 rework runtine #286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#217 rework runtine #286

wants to merge 2 commits into from

Conversation

guillermau
Copy link
Collaborator

closes #217
Breaking runtime changes
Need to update CI and more

@guillermau guillermau self-assigned this Feb 14, 2025
"typecheck": "tsc --noEmit"
"typecheck": "tsc --noEmit",
"dev:db": "docker compose -f ../docker-compose.resources.yml up -d",
"dev:reset": "docker stop sill-postgres-1 && docker rm sill-postgres-1 && docker compose -f ../docker-compose.resources.yml up -d"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ici tu peux aussi faire :

Suggested change
"dev:reset": "docker stop sill-postgres-1 && docker rm sill-postgres-1 && docker compose -f ../docker-compose.resources.yml up -d"
"dev:reset": "docker compose -f ../docker-compose.resources.yml down && rm -rf docker-data && docker compose -f ../docker-compose.resources.yml up -d"

Comment on lines +14 to +15
# volumes:
# - ./docker-data:/var/lib/postgresql/data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est exprès ça ? ça me parait pas une bonne idée. Ça veut dire que les données ne seront plus persisté si tu arrète le container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtine à revoir : Découpler API, update, import puis éviter forever ?
2 participants