Skip to content

Type Model

Type Model #16

GitHub Actions / clippy failed Jan 15, 2025 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (37)

optd-types/src/expression/mod.rs|7 col 39| warning: unused import: PhysicalExpression
--> optd-types/src/expression/mod.rs:7:39
|
7 | pub use relation::{LogicalExpression, PhysicalExpression};
| ^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
optd-types/src/memo/mod.rs|28 col 9| warning: unused variable: expr
--> optd-types/src/memo/mod.rs:28:9
|
28 | expr: LogicalExpression,
| ^^^^ help: if this is intentional, prefix it with an underscore: _expr
|
= note: #[warn(unused_variables)] on by default
optd-types/src/memo/mod.rs|29 col 9| warning: unused variable: rule
--> optd-types/src/memo/mod.rs:29:9
|
29 | rule: Rule,
| ^^^^ help: if this is intentional, prefix it with an underscore: _rule
optd-types/src/memo/mod.rs|36 col 9| warning: unused variable: expr
--> optd-types/src/memo/mod.rs:36:9
|
36 | expr: LogicalExpression,
| ^^^^ help: if this is intentional, prefix it with an underscore: _expr
optd-types/src/memo/mod.rs|37 col 9| warning: unused variable: rule
--> optd-types/src/memo/mod.rs:37:9
|
37 | rule: Rule,
| ^^^^ help: if this is intentional, prefix it with an underscore: _rule
optd-types/src/memo/mod.rs|58 col 45| warning: unused variable: new_exprs
--> optd-types/src/memo/mod.rs:58:45
|
58 | pub async fn add_expressions(&mut self, new_exprs: Vec) {
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _new_exprs
optd-types/src/memo/mod.rs|44 col 9| warning: unused variable: expr
--> optd-types/src/memo/mod.rs:44:9
|
44 | expr: PartialLogicalPlan,
| ^^^^ help: if this is intentional, prefix it with an underscore: _expr
optd-types/src/memo/mod.rs|45 col 9| warning: unused variable: rule
--> optd-types/src/memo/mod.rs:45:9
|
45 | rule: Rule,
| ^^^^ help: if this is intentional, prefix it with an underscore: _rule
optd-types/src/memo/mod.rs|52 col 9| warning: unused variable: expr
--> optd-types/src/memo/mod.rs:52:9
|
52 | expr: PartialPhysicalPlan,
| ^^^^ help: if this is intentional, prefix it with an underscore: _expr
optd-types/src/memo/mod.rs|53 col 9| warning: unused variable: rule
--> optd-types/src/memo/mod.rs:53:9
|
53 | rule: Rule,
| ^^^^ help: if this is intentional, prefix it with an underscore: _rule
optd-types/src/expression/relation/logical.rs|5 col 10| warning: type expression::relation::logical::Scan is more private than the item expression::relation::logical::LogicalExpression::Scan::0
--> optd-types/src/expression/relation/logical.rs:5:10
|
5 | Scan(Scan),
| ^^^^ field expression::relation::logical::LogicalExpression::Scan::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::logical::Scan is only usable at visibility pub(self)
--> optd-types/src/expression/relation/logical.rs:11:1
|
11 | struct Scan {
| ^^^^^^^^^^^
= note: #[warn(private_interfaces)] on by default
optd-types/src/expression/relation/logical.rs|6 col 12| warning: type expression::relation::logical::Filter is more private than the item expression::relation::logical::LogicalExpression::Filter::0
--> optd-types/src/expression/relation/logical.rs:6:12
|
6 | Filter(Filter),
| ^^^^^^ field expression::relation::logical::LogicalExpression::Filter::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::logical::Filter is only usable at visibility pub(self)
--> optd-types/src/expression/relation/logical.rs:15:1
|
15 | struct Filter {
| ^^^^^^^^^^^^^
optd-types/src/expression/relation/logical.rs|7 col 10| warning: type expression::relation::logical::Join is more private than the item expression::relation::logical::LogicalExpression::Join::0
--> optd-types/src/expression/relation/logical.rs:7:10
|
7 | Join(Join),
| ^^^^ field expression::relation::logical::LogicalExpression::Join::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::logical::Join is only usable at visibility pub(self)
--> optd-types/src/expression/relation/logical.rs:20:1
|
20 | struct Join {
| ^^^^^^^^^^^
optd-types/src/expression/relation/logical.rs|8 col 10| warning: type expression::relation::logical::Sort is more private than the item expression::relation::logical::LogicalExpression::Sort::0
--> optd-types/src/expression/relation/logical.rs:8:10
|
8 | Sort(Sort),
| ^^^^ field expression::relation::logical::LogicalExpression::Sort::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::logical::Sort is only usable at visibility pub(self)
--> optd-types/src/expression/relation/logical.rs:26:1
|
26 | struct Sort {
| ^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|5 col 15| warning: type expression::relation::physical::TableScan is more private than the item expression::relation::physical::PhysicalExpression::TableScan::0
--> optd-types/src/expression/relation/physical.rs:5:15
|
5 | TableScan(TableScan),
| ^^^^^^^^^ field expression::relation::physical::PhysicalExpression::TableScan::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::physical::TableScan is only usable at visibility pub(self)
--> optd-types/src/expression/relation/physical.rs:12:1
|
12 | struct TableScan {
| ^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|6 col 20| warning: type expression::relation::physical::PhysicalFilter is more private than the item expression::relation::physical::PhysicalExpression::PhysicalFilter::0
--> optd-types/src/expression/relation/physical.rs:6:20
|
6 | PhysicalFilter(PhysicalFilter),
| ^^^^^^^^^^^^^^ field expression::relation::physical::PhysicalExpression::PhysicalFilter::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::physical::PhysicalFilter is only usable at visibility pub(self)
--> optd-types/src/expression/relation/physical.rs:16:1
|
16 | struct PhysicalFilter {
| ^^^^^^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|7 col 19| warning: type expression::relation::physical::SortMergeJoin is more private than the item expression::relation::physical::PhysicalExpression::SortMergeJoin::0
--> optd-types/src/expression/relation/physical.rs:7:19
|
7 | SortMergeJoin(SortMergeJoin),
| ^^^^^^^^^^^^^ field expression::relation::physical::PhysicalExpression::SortMergeJoin::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::physical::SortMergeJoin is only usable at visibility pub(self)
--> optd-types/src/expression/relation/physical.rs:21:1
|
21 | struct SortMergeJoin {
| ^^^^^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|8 col 14| warning: type expression::relation::physical::HashJoin is more private than the item expression::relation::physical::PhysicalExpression::HashJoin::0
--> optd-types/src/expression/relation/physical.rs:8:14
|
8 | HashJoin(HashJoin),
| ^^^^^^^^ field expression::relation::physical::PhysicalExpression::HashJoin::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::physical::HashJoin is only usable at visibility pub(self)
--> optd-types/src/expression/relation/physical.rs:28:1
|
28 | struct HashJoin {
| ^^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|9 col 15| warning: type expression::relation::physical::MergeSort is more private than the item expression::relation::physical::PhysicalExpression::MergeSort::0
--> optd-types/src/expression/relation/physical.rs:9:15
|
9 | MergeSort(MergeSort),
| ^^^^^^^^^ field expression::relation::physical::PhysicalExpression::MergeSort::0 is reachable at visibility pub(crate)
|
note: but type expression::relation::physical::MergeSort is only usable at visibility pub(self)
--> optd-types/src/expression/relation/physical.rs:34:1
|
34 | struct MergeSort {
| ^^^^^^^^^^^^^^^^
optd-types/src/lib.rs|4 col 12| warning: field 0 is never read
--> optd-types/src/lib.rs:4:20
|
4 | pub struct GroupId(usize);
| ------- ^^^^^
| |
| field in this struct
|
= help: consider removing this field
= note: #[warn(dead_code)] on by default
optd-types/src/expression/mod.rs|10 col 10| warning: enum Expression is never used
--> optd-types/src/expression/mod.rs:10:10
|
10 | pub enum Expression {
| ^^^^^^^^^^
optd-types/src/expression/relation/mod.rs|8 col 10| warning: enum RelationExpression is never used
--> optd-types/src/expression/relation/mod.rs:8:10
|
8 | pub enum RelationExpression {
| ^^^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/logical.rs|4 col 10| warning: enum LogicalExpression is never used
--> optd-types/src/expression/relation/logical.rs:4:10
|
4 | pub enum LogicalExpression {
| ^^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/logical.rs|11 col 8| warning: struct Scan is never constructed
--> optd-types/src/expression/relation/logical.rs:11:8
|
11 | struct Scan {
| ^^^^
optd-types/src/expression/relation/logical.rs|15 col 8| warning: struct Filter is never constructed
--> optd-types/src/expression/relation/logical.rs:15:8
|
15 | struct Filter {
| ^^^^^^
optd-types/src/expression/relation/logical.rs|20 col 8| warning: struct Join is never constructed
--> optd-types/src/expression/relation/logical.rs:20:8
|
20 | struct Join {
| ^^^^
optd-types/src/expression/relation/logical.rs|26 col 8| warning: struct Sort is never constructed
--> optd-types/src/expression/relation/logical.rs:26:8
|
26 | struct Sort {
| ^^^^
optd-types/src/expression/relation/physical.rs|4 col 10| warning: enum PhysicalExpression is never used
--> optd-types/src/expression/relation/physical.rs:4:10
|
4 | pub enum PhysicalExpression {
| ^^^^^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|12 col 8| warning: struct TableScan is never constructed
--> optd-types/src/expression/relation/physical.rs:12:8
|
12 | struct TableScan {
| ^^^^^^^^^
optd-types/src/expression/relation/physical.rs|16 col 8| warning: struct PhysicalFilter is never constructed
--> optd-types/src/expression/relation/physical.rs:16:8
|
16 | struct PhysicalFilter {
| ^^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|21 col 8| warning: struct SortMergeJoin is never constructed
--> optd-types/src/expression/relation/physical.rs:21:8
|
21 | struct SortMergeJoin {
| ^^^^^^^^^^^^^
optd-types/src/expression/relation/physical.rs|28 col 8| warning: struct HashJoin is never constructed
--> optd-types/src/expression/relation/physical.rs:28:8
|
28 | struct HashJoin {
| ^^^^^^^^
optd-types/src/expression/relation/physical.rs|34 col 8| warning: struct MergeSort is never constructed
--> optd-types/src/expression/relation/physical.rs:34:8
|
34 | struct MergeSort {
| ^^^^^^^^^
optd-types/src/expression/scalar.rs|4 col 12| warning: struct ScalarExpression is never constructed
--> optd-types/src/expression/scalar.rs:4:12
|
4 | pub struct ScalarExpression;
| ^^^^^^^^^^^^^^^^
optd-types/src/memo/mod.rs|7 col 10| warning: enum Rule is never used
--> optd-types/src/memo/mod.rs:7:10
|
7 | pub enum Rule {
| ^^^^
optd-types/src/memo/mod.rs|12 col 12| warning: struct Memo is never constructed
--> optd-types/src/memo/mod.rs:12:12
|
12 | pub struct Memo;
| ^^^^
optd-types/src/memo/mod.rs|14 col 1| warning: methods check_transformation, check_implementation, apply_transformation, apply_implementation, and add_expressions are never used
--> optd-types/src/memo/mod.rs:26:18
|
14 | impl Memo {
| --------- methods in this implementation
...
26 | pub async fn check_transformation(
| ^^^^^^^^^^^^^^^^^^^^
...
34 | pub async fn check_implementation(
| ^^^^^^^^^^^^^^^^^^^^
...
42 | pub fn apply_transformation(
| ^^^^^^^^^^^^^^^^^^^^
...
50 | pub fn apply_implementation(
| ^^^^^^^^^^^^^^^^^^^^
...
58 | pub async fn add_expressions(&mut self, new_exprs: Vec) {
| ^^^^^^^^^^^^^^^

Filtered Findings (0)

Annotations

Check warning on line 7 in optd-types/src/expression/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/mod.rs#L7

warning: unused import: `PhysicalExpression`
 --> optd-types/src/expression/mod.rs:7:39
  |
7 | pub use relation::{LogicalExpression, PhysicalExpression};
  |                                       ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
Raw output
optd-types/src/expression/mod.rs:7:39:w:warning: unused import: `PhysicalExpression`
 --> optd-types/src/expression/mod.rs:7:39
  |
7 | pub use relation::{LogicalExpression, PhysicalExpression};
  |                                       ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default


__END__

Check warning on line 28 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L28

warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:28:9
   |
28 |         expr: LogicalExpression,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`
   |
   = note: `#[warn(unused_variables)]` on by default
Raw output
optd-types/src/memo/mod.rs:28:9:w:warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:28:9
   |
28 |         expr: LogicalExpression,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`
   |
   = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 29 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L29

warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:29:9
   |
29 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`
Raw output
optd-types/src/memo/mod.rs:29:9:w:warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:29:9
   |
29 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`


__END__

Check warning on line 36 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L36

warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:36:9
   |
36 |         expr: LogicalExpression,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`
Raw output
optd-types/src/memo/mod.rs:36:9:w:warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:36:9
   |
36 |         expr: LogicalExpression,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`


__END__

Check warning on line 37 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L37

warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:37:9
   |
37 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`
Raw output
optd-types/src/memo/mod.rs:37:9:w:warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:37:9
   |
37 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`


__END__

Check warning on line 58 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L58

warning: unused variable: `new_exprs`
  --> optd-types/src/memo/mod.rs:58:45
   |
58 |     pub async fn add_expressions(&mut self, new_exprs: Vec<Expression>) {
   |                                             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_exprs`
Raw output
optd-types/src/memo/mod.rs:58:45:w:warning: unused variable: `new_exprs`
  --> optd-types/src/memo/mod.rs:58:45
   |
58 |     pub async fn add_expressions(&mut self, new_exprs: Vec<Expression>) {
   |                                             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_exprs`


__END__

Check warning on line 44 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L44

warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:44:9
   |
44 |         expr: PartialLogicalPlan,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`
Raw output
optd-types/src/memo/mod.rs:44:9:w:warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:44:9
   |
44 |         expr: PartialLogicalPlan,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`


__END__

Check warning on line 45 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L45

warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:45:9
   |
45 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`
Raw output
optd-types/src/memo/mod.rs:45:9:w:warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:45:9
   |
45 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`


__END__

Check warning on line 52 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L52

warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:52:9
   |
52 |         expr: PartialPhysicalPlan,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`
Raw output
optd-types/src/memo/mod.rs:52:9:w:warning: unused variable: `expr`
  --> optd-types/src/memo/mod.rs:52:9
   |
52 |         expr: PartialPhysicalPlan,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_expr`


__END__

Check warning on line 53 in optd-types/src/memo/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/memo/mod.rs#L53

warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:53:9
   |
53 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`
Raw output
optd-types/src/memo/mod.rs:53:9:w:warning: unused variable: `rule`
  --> optd-types/src/memo/mod.rs:53:9
   |
53 |         rule: Rule,
   |         ^^^^ help: if this is intentional, prefix it with an underscore: `_rule`


__END__

Check warning on line 5 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L5

warning: type `expression::relation::logical::Scan` is more private than the item `expression::relation::logical::LogicalExpression::Scan::0`
  --> optd-types/src/expression/relation/logical.rs:5:10
   |
5  |     Scan(Scan),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Scan::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Scan` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:11:1
   |
11 | struct Scan {
   | ^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default
Raw output
optd-types/src/expression/relation/logical.rs:5:10:w:warning: type `expression::relation::logical::Scan` is more private than the item `expression::relation::logical::LogicalExpression::Scan::0`
  --> optd-types/src/expression/relation/logical.rs:5:10
   |
5  |     Scan(Scan),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Scan::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Scan` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:11:1
   |
11 | struct Scan {
   | ^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default


__END__

Check warning on line 6 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L6

warning: type `expression::relation::logical::Filter` is more private than the item `expression::relation::logical::LogicalExpression::Filter::0`
  --> optd-types/src/expression/relation/logical.rs:6:12
   |
6  |     Filter(Filter),
   |            ^^^^^^ field `expression::relation::logical::LogicalExpression::Filter::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Filter` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:15:1
   |
15 | struct Filter {
   | ^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/logical.rs:6:12:w:warning: type `expression::relation::logical::Filter` is more private than the item `expression::relation::logical::LogicalExpression::Filter::0`
  --> optd-types/src/expression/relation/logical.rs:6:12
   |
6  |     Filter(Filter),
   |            ^^^^^^ field `expression::relation::logical::LogicalExpression::Filter::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Filter` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:15:1
   |
15 | struct Filter {
   | ^^^^^^^^^^^^^


__END__

Check warning on line 7 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L7

warning: type `expression::relation::logical::Join` is more private than the item `expression::relation::logical::LogicalExpression::Join::0`
  --> optd-types/src/expression/relation/logical.rs:7:10
   |
7  |     Join(Join),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Join::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Join` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:20:1
   |
20 | struct Join {
   | ^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/logical.rs:7:10:w:warning: type `expression::relation::logical::Join` is more private than the item `expression::relation::logical::LogicalExpression::Join::0`
  --> optd-types/src/expression/relation/logical.rs:7:10
   |
7  |     Join(Join),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Join::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Join` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:20:1
   |
20 | struct Join {
   | ^^^^^^^^^^^


__END__

Check warning on line 8 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L8

warning: type `expression::relation::logical::Sort` is more private than the item `expression::relation::logical::LogicalExpression::Sort::0`
  --> optd-types/src/expression/relation/logical.rs:8:10
   |
8  |     Sort(Sort),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Sort::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Sort` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:26:1
   |
26 | struct Sort {
   | ^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/logical.rs:8:10:w:warning: type `expression::relation::logical::Sort` is more private than the item `expression::relation::logical::LogicalExpression::Sort::0`
  --> optd-types/src/expression/relation/logical.rs:8:10
   |
8  |     Sort(Sort),
   |          ^^^^ field `expression::relation::logical::LogicalExpression::Sort::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::logical::Sort` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/logical.rs:26:1
   |
26 | struct Sort {
   | ^^^^^^^^^^^


__END__

Check warning on line 5 in optd-types/src/expression/relation/physical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/physical.rs#L5

warning: type `expression::relation::physical::TableScan` is more private than the item `expression::relation::physical::PhysicalExpression::TableScan::0`
  --> optd-types/src/expression/relation/physical.rs:5:15
   |
5  |     TableScan(TableScan),
   |               ^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::TableScan::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::TableScan` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:12:1
   |
12 | struct TableScan {
   | ^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/physical.rs:5:15:w:warning: type `expression::relation::physical::TableScan` is more private than the item `expression::relation::physical::PhysicalExpression::TableScan::0`
  --> optd-types/src/expression/relation/physical.rs:5:15
   |
5  |     TableScan(TableScan),
   |               ^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::TableScan::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::TableScan` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:12:1
   |
12 | struct TableScan {
   | ^^^^^^^^^^^^^^^^


__END__

Check warning on line 6 in optd-types/src/expression/relation/physical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/physical.rs#L6

warning: type `expression::relation::physical::PhysicalFilter` is more private than the item `expression::relation::physical::PhysicalExpression::PhysicalFilter::0`
  --> optd-types/src/expression/relation/physical.rs:6:20
   |
6  |     PhysicalFilter(PhysicalFilter),
   |                    ^^^^^^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::PhysicalFilter::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::PhysicalFilter` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:16:1
   |
16 | struct PhysicalFilter {
   | ^^^^^^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/physical.rs:6:20:w:warning: type `expression::relation::physical::PhysicalFilter` is more private than the item `expression::relation::physical::PhysicalExpression::PhysicalFilter::0`
  --> optd-types/src/expression/relation/physical.rs:6:20
   |
6  |     PhysicalFilter(PhysicalFilter),
   |                    ^^^^^^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::PhysicalFilter::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::PhysicalFilter` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:16:1
   |
16 | struct PhysicalFilter {
   | ^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 7 in optd-types/src/expression/relation/physical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/physical.rs#L7

warning: type `expression::relation::physical::SortMergeJoin` is more private than the item `expression::relation::physical::PhysicalExpression::SortMergeJoin::0`
  --> optd-types/src/expression/relation/physical.rs:7:19
   |
7  |     SortMergeJoin(SortMergeJoin),
   |                   ^^^^^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::SortMergeJoin::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::SortMergeJoin` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:21:1
   |
21 | struct SortMergeJoin {
   | ^^^^^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/physical.rs:7:19:w:warning: type `expression::relation::physical::SortMergeJoin` is more private than the item `expression::relation::physical::PhysicalExpression::SortMergeJoin::0`
  --> optd-types/src/expression/relation/physical.rs:7:19
   |
7  |     SortMergeJoin(SortMergeJoin),
   |                   ^^^^^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::SortMergeJoin::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::SortMergeJoin` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:21:1
   |
21 | struct SortMergeJoin {
   | ^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 8 in optd-types/src/expression/relation/physical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/physical.rs#L8

warning: type `expression::relation::physical::HashJoin` is more private than the item `expression::relation::physical::PhysicalExpression::HashJoin::0`
  --> optd-types/src/expression/relation/physical.rs:8:14
   |
8  |     HashJoin(HashJoin),
   |              ^^^^^^^^ field `expression::relation::physical::PhysicalExpression::HashJoin::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::HashJoin` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:28:1
   |
28 | struct HashJoin {
   | ^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/physical.rs:8:14:w:warning: type `expression::relation::physical::HashJoin` is more private than the item `expression::relation::physical::PhysicalExpression::HashJoin::0`
  --> optd-types/src/expression/relation/physical.rs:8:14
   |
8  |     HashJoin(HashJoin),
   |              ^^^^^^^^ field `expression::relation::physical::PhysicalExpression::HashJoin::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::HashJoin` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:28:1
   |
28 | struct HashJoin {
   | ^^^^^^^^^^^^^^^


__END__

Check warning on line 9 in optd-types/src/expression/relation/physical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/physical.rs#L9

warning: type `expression::relation::physical::MergeSort` is more private than the item `expression::relation::physical::PhysicalExpression::MergeSort::0`
  --> optd-types/src/expression/relation/physical.rs:9:15
   |
9  |     MergeSort(MergeSort),
   |               ^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::MergeSort::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::MergeSort` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:34:1
   |
34 | struct MergeSort {
   | ^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/physical.rs:9:15:w:warning: type `expression::relation::physical::MergeSort` is more private than the item `expression::relation::physical::PhysicalExpression::MergeSort::0`
  --> optd-types/src/expression/relation/physical.rs:9:15
   |
9  |     MergeSort(MergeSort),
   |               ^^^^^^^^^ field `expression::relation::physical::PhysicalExpression::MergeSort::0` is reachable at visibility `pub(crate)`
   |
note: but type `expression::relation::physical::MergeSort` is only usable at visibility `pub(self)`
  --> optd-types/src/expression/relation/physical.rs:34:1
   |
34 | struct MergeSort {
   | ^^^^^^^^^^^^^^^^


__END__

Check warning on line 4 in optd-types/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/lib.rs#L4

warning: field `0` is never read
 --> optd-types/src/lib.rs:4:20
  |
4 | pub struct GroupId(usize);
  |            ------- ^^^^^
  |            |
  |            field in this struct
  |
  = help: consider removing this field
  = note: `#[warn(dead_code)]` on by default
Raw output
optd-types/src/lib.rs:4:12:w:warning: field `0` is never read
 --> optd-types/src/lib.rs:4:20
  |
4 | pub struct GroupId(usize);
  |            ------- ^^^^^
  |            |
  |            field in this struct
  |
  = help: consider removing this field
  = note: `#[warn(dead_code)]` on by default


__END__

Check warning on line 10 in optd-types/src/expression/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/mod.rs#L10

warning: enum `Expression` is never used
  --> optd-types/src/expression/mod.rs:10:10
   |
10 | pub enum Expression {
   |          ^^^^^^^^^^
Raw output
optd-types/src/expression/mod.rs:10:10:w:warning: enum `Expression` is never used
  --> optd-types/src/expression/mod.rs:10:10
   |
10 | pub enum Expression {
   |          ^^^^^^^^^^


__END__

Check warning on line 8 in optd-types/src/expression/relation/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/mod.rs#L8

warning: enum `RelationExpression` is never used
 --> optd-types/src/expression/relation/mod.rs:8:10
  |
8 | pub enum RelationExpression {
  |          ^^^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/mod.rs:8:10:w:warning: enum `RelationExpression` is never used
 --> optd-types/src/expression/relation/mod.rs:8:10
  |
8 | pub enum RelationExpression {
  |          ^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 4 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L4

warning: enum `LogicalExpression` is never used
 --> optd-types/src/expression/relation/logical.rs:4:10
  |
4 | pub enum LogicalExpression {
  |          ^^^^^^^^^^^^^^^^^
Raw output
optd-types/src/expression/relation/logical.rs:4:10:w:warning: enum `LogicalExpression` is never used
 --> optd-types/src/expression/relation/logical.rs:4:10
  |
4 | pub enum LogicalExpression {
  |          ^^^^^^^^^^^^^^^^^


__END__

Check warning on line 11 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L11

warning: struct `Scan` is never constructed
  --> optd-types/src/expression/relation/logical.rs:11:8
   |
11 | struct Scan {
   |        ^^^^
Raw output
optd-types/src/expression/relation/logical.rs:11:8:w:warning: struct `Scan` is never constructed
  --> optd-types/src/expression/relation/logical.rs:11:8
   |
11 | struct Scan {
   |        ^^^^


__END__

Check warning on line 15 in optd-types/src/expression/relation/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] optd-types/src/expression/relation/logical.rs#L15

warning: struct `Filter` is never constructed
  --> optd-types/src/expression/relation/logical.rs:15:8
   |
15 | struct Filter {
   |        ^^^^^^
Raw output
optd-types/src/expression/relation/logical.rs:15:8:w:warning: struct `Filter` is never constructed
  --> optd-types/src/expression/relation/logical.rs:15:8
   |
15 | struct Filter {
   |        ^^^^^^


__END__