Checkout Cargo.lock file and bump MSRV
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlSchlo
approved these changes
Jan 28, 2025
Merged
connortsui20
changed the title
Cargo.lock fileCargo.lock file and bump MSRV
SarveshOO7
approved these changes
Jan 29, 2025
yliang412
approved these changes
Jan 29, 2025
AlSchlo
added a commit
that referenced
this pull request
Jan 29, 2025
This PR models almost all of the types that will be necessary for optimization. This includes: - generic relational algebra operators that allow us to use the same "type" for both expressions in the memo table and operators in the plans - logical / physical plans - scalar operators and expressions - partially materialized logical plans for rule binding - transformation rule + implementation rule trait and some empty structs that implement them I've named the crate itself `optd-core`. This can be subject to change, but I feel this is a reasonable default for now. ~~TODO: need to wait on #3 and #12 to be merged before proper CI checks can happen~~ Edit: I removed the `cargo rustdoc` check because its creating more problem than it would solve, see #14 --------- Co-authored-by: Alexis Schlomer <aschlome@andrew.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I somehow forgot to check this out, so adding this to what git tracks. By checking this out, we make sure everyone is developing on the same versions of this project.
As for the question of if we should check this out, see this conversation.
I also modified the .gitignore because there was a weird comment in there.
(Will fix the msrv error soon)