Process completed with exit code 101.

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

warning: this expression creates a reference which is immediately dereferenced by the compiler --> optd/src/storage.rs:35:54 | 35 | let connection = SqliteConnection::establish(&database_url)?; | ^^^^^^^^^^^^^ help: change this to: `database_url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: returning the result of a `let` binding from a block --> optd/src/storage.rs:114:9 | 108 | / let rel_group_id = logical_exprs 109 | | .filter(id.eq(logical_expr)) 110 | | .select(group_id) 111 | | .first(&mut self.conn) 112 | | .expect("Invalid database state: logical expression must belongs to a group"); | |__________________________________________________________________________________________- unnecessary `let` binding 113 | 114 | rel_group_id | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 108 ~ 109 | 110 ~ logical_exprs 111 + .filter(id.eq(logical_expr)) 112 + .select(group_id) 113 + .first(&mut self.conn) 114 + .expect("Invalid database state: logical expression must belongs to a group") |

warning: matching on `Some` with `ok()` is redundant --> optd/src/bin/storage_demo_manual.rs:44:9 | 44 | / if let Some(expr_id) = logical_scans::table 45 | | .filter(logical_scans::table_name.eq(&scan.table_name)) 46 | | .select(logical_scans::logical_expr_id) 47 | | .first::<LogicalExprId>(&mut storage.conn) 48 | | .ok() | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok = note: `#[warn(clippy::match_result_ok)]` on by default help: consider matching on `Ok(expr_id)` and removing the call to `ok` instead | 44 ~ if let Ok(expr_id) = logical_scans::table 45 + .filter(logical_scans::table_name.eq(&scan.table_name)) 46 + .select(logical_scans::logical_expr_id) 47 + .first::<LogicalExprId>(&mut storage.conn) |

warning: matching on `Some` with `ok()` is redundant --> optd/src/bin/storage_demo_manual.rs:91:9 | 91 | / if let Some(expr_id) = logical_scans::table 92 | | .filter(logical_scans::table_name.eq(&scan.table_name)) 93 | | .select(logical_scans::logical_expr_id) 94 | | .first::<LogicalExprId>(&mut storage.conn) 95 | | .ok() | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok help: consider matching on `Ok(expr_id)` and removing the call to `ok` instead | 91 ~ if let Ok(expr_id) = logical_scans::table 92 + .filter(logical_scans::table_name.eq(&scan.table_name)) 93 + .select(logical_scans::logical_expr_id) 94 + .first::<LogicalExprId>(&mut storage.conn) |

warning: matching on `Some` with `ok()` is redundant --> optd/src/bin/storage_demo_manual.rs:141:9 | 141 | / if let Some(expr_id) = logical_joins::table 142 | | .filter(logical_joins::left.eq(&join.left)) 143 | | .filter(logical_joins::right.eq(&join.right)) 144 | | .filter(logical_joins::join_type.eq(&join.join_type)) ... | 147 | | .first::<LogicalExprId>(&mut storage.conn) 148 | | .ok() | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok help: consider matching on `Ok(expr_id)` and removing the call to `ok` instead | 141 ~ if let Ok(expr_id) = logical_joins::table 142 + .filter(logical_joins::left.eq(&join.left)) 143 + .filter(logical_joins::right.eq(&join.right)) 144 + .filter(logical_joins::join_type.eq(&join.join_type)) 145 + .filter(logical_joins::join_cond.eq(&join.join_cond)) 146 + .select(logical_joins::logical_expr_id) 147 + .first::<LogicalExprId>(&mut storage.conn) |

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

warning: this expression creates a reference which is immediately dereferenced by the compiler --> optd/src/storage.rs:35:54 | 35 | let connection = SqliteConnection::establish(&database_url)?; | ^^^^^^^^^^^^^ help: change this to: `database_url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: returning the result of a `let` binding from a block --> optd/src/storage.rs:114:9 | 108 | / let rel_group_id = logical_exprs 109 | | .filter(id.eq(logical_expr)) 110 | | .select(group_id) 111 | | .first(&mut self.conn) 112 | | .expect("Invalid database state: logical expression must belongs to a group"); | |__________________________________________________________________________________________- unnecessary `let` binding 113 | 114 | rel_group_id | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 108 ~ 109 | 110 ~ logical_exprs 111 + .filter(id.eq(logical_expr)) 112 + .select(group_id) 113 + .first(&mut self.conn) 114 + .expect("Invalid database state: logical expression must belongs to a group") |

warning: matching on `Some` with `ok()` is redundant --> optd/src/bin/storage_demo_manual.rs:44:9 | 44 | / if let Some(expr_id) = logical_scans::table 45 | | .filter(logical_scans::table_name.eq(&scan.table_name)) 46 | | .select(logical_scans::logical_expr_id) 47 | | .first::<LogicalExprId>(&mut storage.conn) 48 | | .ok() | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok = note: `#[warn(clippy::match_result_ok)]` on by default help: consider matching on `Ok(expr_id)` and removing the call to `ok` instead | 44 ~ if let Ok(expr_id) = logical_scans::table 45 + .filter(logical_scans::table_name.eq(&scan.table_name)) 46 + .select(logical_scans::logical_expr_id) 47 + .first::<LogicalExprId>(&mut storage.conn) |

warning: matching on `Some` with `ok()` is redundant --> optd/src/bin/storage_demo_manual.rs:91:9 | 91 | / if let Some(expr_id) = logical_scans::table 92 | | .filter(logical_scans::table_name.eq(&scan.table_name)) 93 | | .select(logical_scans::logical_expr_id) 94 | | .first::<LogicalExprId>(&mut storage.conn) 95 | | .ok() | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok help: consider matching on `Ok(expr_id)` and removing the call to `ok` instead | 91 ~ if let Ok(expr_id) = logical_scans::table 92 + .filter(logical_scans::table_name.eq(&scan.table_name)) 93 + .select(logical_scans::logical_expr_id) 94 + .first::<LogicalExprId>(&mut storage.conn) |