Add particle type parameter to ellipsoid_gsd method. Remove rigid body methods from gsd_utils
#102
+46
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also removing the rigid body helper methods, I don't think they are being used anywhere now that floewrMD handles it internally for ellipsoids, and GMSO has open PR that will handle everything needed to use rigid bodies for molecules. |
chrisjonesBSU
changed the title
ellipsoid_gsd methodellipsoid_gsd method. Remove rigid body methods from gsd_utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ellipsoid_gsd()was hard-coded for a specific model/approach of ellipsoids, and therefore didn't work when the arrangement of ghost particles changed. This PR adds a parameter where you can specify which particle types should be drawn as ellipsoids, and all others are drawn as spheres.