Support of string pointers in blob-lang expressions #92
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed the PR as this is not actually an issue, which I realized after fixing another bug in our project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protoc-gen-go generates string pointers when a string is optional.
protoc-gen-go-temporal currently does not support string pointers in blob-lang expressions.
This PR adds support for that and add tests. Note that there is no need to check for a nil string pointer, as that is handled automatically. There is for a non-nil string pointer id and a test for a nil string pointer id.
NOTE: I did not regenerate the generated files in this PR, as the generated code used new versions and the formatting was changed quite a bit. I will leave that to you, unless you want me to do it.