-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add restart policy and version consistency parameters #193
Merged
gberenice
merged 2 commits into
cloudposse:main
from
ia9:feature/add-restart-policy-and-version-consistency-parameters
Feb 28, 2025
Merged
feature: Add restart policy and version consistency parameters #193
gberenice
merged 2 commits into
cloudposse:main
from
ia9:feature/add-restart-policy-and-version-consistency-parameters
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes #192 since that PR seems to have gone stale |
/terratest |
@ia9 thanks for your contribution! Error: Not equal:
expected: "map[cpu:256 environment:[map[name:false_boolean_var value:false] map[name:integer_var value:42] map[name:string_var value:I am a string] map[name:true_boolean_var value:true]] essential:true extraHosts:[map[hostname:app.local ipAddress:127.0.0.1]] hostname:hostname image:cloudposse/geodesic interactive:true logConfiguration:map[logDriver:json-file options:map[max-file:3 max-size:10m]] memory:256 memoryReservation:128 name:app portMappings:[map[appProtocol:http containerPort:8080 hostPort:80 name:http protocol:tcp] map[appProtocol:http containerPort:8081 hostPort:443 name:https protocol:udp]] privileged:false pseudoTerminal:true readonlyRootFilesystem:false restartPolicy:map[enabled:true ignoredExitCodes:[0] restartAttemptPeriod:<nil>] versionConsistency:enabled]"
actual : "map[cpu:256 environment:[map[name:false_boolean_var value:false] map[name:integer_var value:42] map[name:string_var value:I am a string] map[name:true_boolean_var value:true]] essential:true extraHosts:[map[hostname:app.local ipAddress:127.0.0.1]] hostname:hostname image:cloudposse/geodesic interactive:true logConfiguration:map[logDriver:json-file options:map[max-file:3 max-size:10m]] memory:256 memoryReservation:128 name:app portMappings:[map[appProtocol:http containerPort:8080 hostPort:80 name:http protocol:tcp] map[appProtocol:http containerPort:8081 hostPort:443 name:https protocol:udp]] privileged:false pseudoTerminal:true readonlyRootFilesystem:false restartPolicy:map[enabled:true ignoredExitCodes:[0]] versionConsistency:enabled]"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-map[cpu:256 environment:[map[name:false_boolean_var value:false] map[name:integer_var value:42] map[name:string_var value:I am a string] map[name:true_boolean_var value:true]] essential:true extraHosts:[map[hostname:app.local ipAddress:127.0.0.1]] hostname:hostname image:cloudposse/geodesic interactive:true logConfiguration:map[logDriver:json-file options:map[max-file:3 max-size:10m]] memory:256 memoryReservation:128 name:app portMappings:[map[appProtocol:http containerPort:8080 hostPort:80 name:http protocol:tcp] map[appProtocol:http containerPort:8081 hostPort:443 name:https protocol:udp]] privileged:false pseudoTerminal:true readonlyRootFilesystem:false restartPolicy:map[enabled:true ignoredExitCodes:[0] restartAttemptPeriod:<nil>] versionConsistency:enabled]
+map[cpu:256 environment:[map[name:false_boolean_var value:false] map[name:integer_var value:42] map[name:string_var value:I am a string] map[name:true_boolean_var value:true]] essential:true extraHosts:[map[hostname:app.local ipAddress:127.0.0.1]] hostname:hostname image:cloudposse/geodesic interactive:true logConfiguration:map[logDriver:json-file options:map[max-file:3 max-size:10m]] memory:256 memoryReservation:128 name:app portMappings:[map[appProtocol:http containerPort:8080 hostPort:80 name:http protocol:tcp] map[appProtocol:http containerPort:8081 hostPort:443 name:https protocol:udp]] privileged:false pseudoTerminal:true readonlyRootFilesystem:false restartPolicy:map[enabled:true ignoredExitCodes:[0]] versionConsistency:enabled]
Test: TestExamplesComplete |
/terratest |
@gberenice Let me know if there's anything else needed here |
gberenice
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These changes were released in v0.61.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
restartPolicy
parameterversionConsistency
parametercomplete
examplewhy
In order to support new parameters added to container definition.
restartPolicy
parameterversionConsistency
parameter added in AWS provider v5.77.0references