Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-24453: Update API-docs for Azure plugin, support for resource groups #614

Merged

Conversation

dgiguere-aptum
Copy link

@dgiguere-aptum dgiguere-aptum commented Mar 18, 2024

Fixes MC-24453

Changes made

  • API-docs: Added support for resourceGroupName for some entities in Azure plugin

Related PRs

  • This is related to feature branch of MC-24453 in cloudmc-azure-plugin

Copy link

@fyrnaga fyrnaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for modifying this. However, we will need to have the API docs done through the code instead of here. This is something to be deprecated.

@dgiguere-aptum dgiguere-aptum merged commit 159f69c into cmc-dev Mar 18, 2024
@dgiguere-aptum dgiguere-aptum deleted the feature/MC-24453-update-api-docs-azure-resource-groups branch March 18, 2024 20:10
@dgiguere-aptum
Copy link
Author

Oh, thanks for the info. In the Azure plugin, there are no @Describe annotations, so I concluded it was manual updates. I noted it for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants