Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cancel concurrent lint and test workflows #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m4s-b3n
Copy link

@m4s-b3n m4s-b3n commented Feb 19, 2025

This pull request introduces concurrency settings to multiple GitHub Actions workflows to prevent overlapping runs and ensure that only the latest run is processed. The most important changes include the addition of concurrency groups and the cancellation of in-progress runs.

Concurrency settings added to GitHub Actions workflows:

Signed-off-by: Marius Boden <marius.boden@xebia.com>
@m4s-b3n
Copy link
Author

m4s-b3n commented Feb 21, 2025

@itay-grudev this one might spare you some approvals / pending workflows

@itay-grudev
Copy link
Collaborator

Isn't this useful sometimes? If you commit quickly, but the old CI pipeline failed as well. It helps you narrow the source of the issue?

@itay-grudev
Copy link
Collaborator

It would be super nice if the tests ran without approval, as long as only chart files have been changed. I haven't looked into that. I am way more familiar with GitLab CI, than GitHub Actions.

@m4s-b3n
Copy link
Author

m4s-b3n commented Feb 22, 2025

Isn't this useful sometimes? If you commit quickly, but the old CI pipeline failed as well. It helps you narrow the source of the issue?

If you don't wait for the result it might not be worth it ;) but for you as a maintainer it would eventually be easier to decide wich workflows really need approval. I feel that useful in my workflows, but as you say nothing comes without a tradeoff ...

@m4s-b3n
Copy link
Author

m4s-b3n commented Feb 22, 2025

It would be super nice if the tests ran without approval, as long as only chart files have been changed. I haven't looked into that. I am way more familiar with GitLab CI, than GitHub Actions.

Did Gitlab in the past a lot but nowadays mostly GitHub. If you need support on that let me know. I'd love to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants