Merge pull request #58 from cloudinary/v3.1.1

v3.1.1: changed default crop from fit to limit
cloudinary · Mar 19, 2020 · 0166000 · 0166000
2 parents 6d8262b + ed41baa
commit 0166000
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 9 deletions.
diff --git a/app/code/community/Cloudinary/Cloudinary/Helper/Image.php b/app/code/community/Cloudinary/Cloudinary/Helper/Image.php
@@ -147,7 +147,8 @@ private function createTransformation()
         } else {
             return $this->_configuration->getDefaultTransformation()
                 ->withDimensions($this->_dimensions)
-                ->withCrop(Crop::fit());
+                //->withCrop(Crop::fit());
+                ->withCrop(Crop::limit());
         }
     }
 }
diff --git a/lib/CloudinaryExtension/Image/Transformation/Crop.php b/lib/CloudinaryExtension/Image/Transformation/Crop.php
@@ -4,8 +4,10 @@
 
 class Crop
 {
-    const PAD = 'lpad';
+    const PAD = 'pad';
+    const LPAD = 'lpad';
     const FIT = 'fit';
+    const LIMIT = 'limit';
 
     private $value;
 
@@ -24,11 +26,21 @@ public static function pad()
         return new Crop(self::PAD);
     }
 
+    public static function lpad()
+    {
+        return new Crop(self::LPAD);
+    }
+
     public static function fit()
     {
         return new Crop(self::FIT);
     }
 
+    public static function limit()
+    {
+        return new Crop(self::LIMIT);
+    }
+
     public function __toString()
     {
         return $this->value;

diff --git a/var/connect/Cloudinary_Cloudinary-3.1.0.tgz b/var/connect/Cloudinary_Cloudinary-3.1.0.tgz
diff --git a/var/connect/Cloudinary_Cloudinary-3.1.1.tgz b/var/connect/Cloudinary_Cloudinary-3.1.1.tgz
diff --git a/var/connect/Cloudinary_Cloudinary.xml b/var/connect/Cloudinary_Cloudinary.xml
@@ -1,5 +1,5 @@
 <_>
-   <form_key>3F4BbWrCQHzufos5</form_key>
+   <form_key>UQi1chJu9f8zOXQ6</form_key>
    <name>Cloudinary_Cloudinary</name>
    <channel>community</channel>
    <version_ids>
@@ -9,7 +9,7 @@
    <description>Cloudinary supercharges your images! Upload images to the cloud, deliver optimized via a fast CDN, perform smart resizing and apply effects.</description>
    <license>MIT License (MITL)</license>
    <license_uri/>
-   <version>3.1.0</version>
+   <version>3.1.1</version>
    <stability>stable</stability>
    <notes>      - Match MEQP1 coding standards
    </notes>
@@ -41,7 +41,7 @@
             <max/>
          </max>
          <files>
-            <files>                                     </files>
+            <files>                                      </files>
          </files>
       </package>
       <extension>
@@ -103,4 +103,8 @@
          <ignore/>
       </ignore>
    </contents>
+   <page>1</page>
+   <limit>200</limit>
+   <folder/>
+   <package/>
 </_>
diff --git a/var/connect/package.xml b/var/connect/package.xml