Remove HeaderExt and AbortSignalExt #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #617
kflansburg
commented
Aug 19, 2024
| @@ -13,7 +13,7 @@ wasm-bindgen.workspace = true | |||
| cfg-if = "1.0.0" | |||
|
|
|||
| [dependencies.web-sys] | |||
| version = "0.3.63" | |||
| version = ">=0.3.70" | |||
There was a problem hiding this comment.
Hopefully this prevents folks with an older version in their Cargo.lock from running into the reverse issue.
kflansburg
commented
Aug 19, 2024
| @@ -1,42 +0,0 @@ | |||
| use wasm_bindgen::prelude::*; | |||
There was a problem hiding this comment.
Looks like they also added the methods implemented by AbortSignalExt
renovate bot
referenced
this pull request
in spiraldb/vortex
Aug 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [worker](https://togithub.com/cloudflare/workers-rs) | workspace.dependencies | patch | `0.3.3` -> `0.3.4` | --- ### Release Notes <details> <summary>cloudflare/workers-rs (worker)</summary> ### [`v0.3.4`](https://togithub.com/cloudflare/workers-rs/releases/tag/v0.3.4) [Compare Source](https://togithub.com/cloudflare/workers-rs/compare/v0.3.3...v0.3.4) #### What's Changed - Fix breaking change in `js-sys` / `web-sys`. Remove HeaderExt and AbortSignalExt by [@​kflansburg](https://togithub.com/kflansburg) in [https://github.com/cloudflare/workers-rs/pull/621](https://togithub.com/cloudflare/workers-rs/pull/621) **Full Changelog**: cloudflare/workers-rs@v0.3.3...v0.3.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/spiraldb/vortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kanarus
added a commit
to ohkami-rs/ohkami
that referenced
this pull request
Aug 20, 2024
kanarus
added a commit
to ohkami-rs/ohkami
that referenced
this pull request
Aug 20, 2024
* @2024-08-13 18:25+9:00
* next: add `format::{Query, builtin::〜}`
* next: update examples
* next: in-place validation with `Schema` specialization in nightly
* @2024-08-14 03:11+9:00
* next: docs
* next: pass CI
* wait cloudflare/workers-rs#619 to be merged
* fix doc of `format::File`
* thanks to cloudflare/workers-rs#621 & fix benches/src/bin
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-sysintroduced methods which render these extensions unneededCloses #617
Thanks to @omarabid for finding this!