Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxComments to GitHub and BitBucker #927

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Add maxComments to GitHub and BitBucker #927

merged 2 commits into from
Mar 25, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

@prymitive prymitive changed the title Dedup Add maxComments to GitHub and BitBucker Mar 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.56.2-4-gab6da53
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Mar 25, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   86.62m ± 2%   86.58m ± 2%       ~ (p=0.971 n=10)
CheckRules-4    87.18m ± 0%   88.22m ± 1%  +1.18% (p=0.002 n=10)
geomean         86.90m        87.39m       +0.57%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   54.00Mi ± 0%   54.00Mi ± 0%       ~ (p=0.912 n=10)
CheckRules-4    84.06Mi ± 0%   84.06Mi ± 0%       ~ (p=0.631 n=10)
geomean         67.38Mi        67.38Mi       +0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   434.0k ± 0%   434.0k ± 0%       ~ (p=0.669 n=10)
CheckRules-4    879.1k ± 0%   879.1k ± 0%       ~ (p=0.631 n=10)
geomean         617.7k        617.7k       +0.00%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (54ccdd8) to head (6cc4900).

❗ Current head 6cc4900 differs from pull request most recent head ab6da53. Consider uploading reports for the commit ab6da53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
+ Coverage   95.02%   95.05%   +0.03%     
==========================================
  Files          93       93              
  Lines        8925     8982      +57     
==========================================
+ Hits         8481     8538      +57     
  Misses        305      305              
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 703d83a into main Mar 25, 2024
20 checks passed
@prymitive prymitive deleted the dedup branch March 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants