Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query/cost reporting #923

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix query/cost reporting #923

merged 1 commit into from
Mar 22, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.56.1-1-gee1fe2e
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   88.99m ± 3%   86.67m ± 1%       ~ (p=0.123 n=10)
CheckRules-4    88.50m ± 1%   88.19m ± 1%       ~ (p=0.280 n=10)
geomean         88.75m        87.43m       -1.49%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   54.00Mi ± 0%   54.00Mi ± 0%       ~ (p=0.971 n=10)
CheckRules-4    84.06Mi ± 0%   84.06Mi ± 0%       ~ (p=0.280 n=10)
geomean         67.37Mi        67.38Mi       +0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   434.0k ± 0%   434.0k ± 0%       ~ (p=0.956 n=10)
CheckRules-4    879.1k ± 0%   879.1k ± 0%       ~ (p=0.353 n=10)
geomean         617.7k        617.7k       +0.00%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (4662448) to head (ee1fe2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          93       93           
  Lines        8917     8923    +6     
=======================================
+ Hits         8473     8479    +6     
  Misses        305      305           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit d14c85f into main Mar 22, 2024
20 checks passed
@prymitive prymitive deleted the query/cost branch March 22, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants