Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #917

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove dead code #917

merged 1 commit into from
Mar 18, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   86.66m ± 1%   87.00m ± 1%       ~ (p=0.280 n=10)
CheckRules-4    87.79m ± 1%   87.42m ± 1%       ~ (p=0.063 n=10)
geomean         87.22m        87.21m       -0.01%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   54.00Mi ± 0%   54.00Mi ± 0%       ~ (p=0.393 n=10)
CheckRules-4    84.06Mi ± 0%   84.06Mi ± 0%       ~ (p=0.739 n=10)
geomean         67.37Mi        67.38Mi       +0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   434.0k ± 0%   434.0k ± 0%       ~ (p=0.726 n=10)
CheckRules-4    879.1k ± 0%   879.1k ± 0%       ~ (p=0.926 n=10)
geomean         617.7k        617.7k       +0.00%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.55.0-12-g01df83e
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@prymitive prymitive merged commit 7e117c8 into main Mar 18, 2024
20 checks passed
@prymitive prymitive deleted the parser branch March 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant