Fix nil pointer exceptions in certain broken dependency scenarios #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are one or more broken dependency problems, the final value of `dep` when evaluating all entries is the one used when preparing the problem item. However, it is possible that after a problem is identified, subsequent entries are recording or alerting rules which either do not have any vector selectors, or none that match. In this situation, the final value of `dep` is `nil`, which causes a crash. This change fixes this by using the first broken dependency entry recorded for building this part of the string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 93 93
Lines 8797 8797
=======================================
Hits 8345 8345
Misses 311 311
Partials 141 141 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are one or more broken dependency problems, the final value of
depwhen evaluating all entries is the one used when preparing the problem item.However, it is possible that after a problem is identified, subsequent entries are recording or alerting rules which either do not have any vector selectors, or none that match.
In this situation, the final value of
depisnil, which causes a crash.This change fixes this by using the first broken dependency entry recorded for building this part of the string.