Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default check to ensure label values are strings #839

Conversation

douglascamata
Copy link

Prometheus won't accept labels with values that aren't strings. This issue is often accidentally hit because YAML parsers try to parse certain unquoted identifiers to built-in types (booleans, integers, etc). So things like true become a boolean and 1 an integer.

@douglascamata
Copy link
Author

Hey @prymitive, any chance you could have a look at this, please? 🙏

prymitive added a commit that referenced this pull request Mar 1, 2024
@prymitive prymitive mentioned this pull request Mar 1, 2024
@prymitive
Copy link
Collaborator

Thanks for the PR but this doesn't really belong in a check.
This is part of a parser validation and so I've raised a PR for checks there - #890

@prymitive prymitive closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants