Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add QA and base cmd/entry #1

Open
wants to merge 1 commit into
base: alpine
Choose a base branch
from

Conversation

lasley
Copy link

@lasley lasley commented Jan 4, 2017

Testing of LasLabs/docker-quality-tools#1

  • Add a base docker-entrypoint
  • Add a base cmd cat
  • Add a Travis file
  • Add a ReadMe

@lasley lasley force-pushed the feature/alpine/travis branch from f91068f to 03be991 Compare January 4, 2017 05:28
@@ -1,8 +1,13 @@
FROM alpine:latest
FROM alpine:3.5
MAINTAINER Yannick Buron yburon@goclouder.net

RUN apk add --update ssmtp wget curl rsync bash
Copy link
Author

@lasley lasley Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lint failing here for using both curl & wget - clouder-community/clouder#194

I will disable the lint here for the time being

@lasley lasley mentioned this pull request Jan 4, 2017
@lasley lasley force-pushed the feature/alpine/travis branch 4 times, most recently from 56acb3f to f10c5f5 Compare January 4, 2017 06:55
* Add a base docker-entrypoint
* Add a base cmd `cat`
* Add a Travis file
* Add a ReadMe
* Fix Lint DL3007 in Dockerfile, stick alpine version
@lasley lasley force-pushed the feature/alpine/travis branch from f10c5f5 to 478cd0c Compare January 4, 2017 07:06
@YannickB
Copy link
Contributor

YannickB commented Jan 4, 2017

Hum this repo will not be used anymore because we moved the images in https://github.com/clouder-community/clouder/tree/master/clouder/images/base. No use to update here, do you have a way to make it happen there ?

@lasley
Copy link
Author

lasley commented Jan 4, 2017

We need it to be in its own repo. I thought that every image was in its own repo? How are you pushing to Dockerhub?

@YannickB
Copy link
Contributor

YannickB commented Jan 4, 2017

We decided to move them in the main repo, for easier contributions from other developers and also resolve the problem of multi repo which would make the move in the OCA very difficult. I think there is no turning back here.

We did it when I realised we can in Dockerhub specify where is located the Dockerfile, then allowing the have several image in same repo.

@lasley
Copy link
Author

lasley commented Jan 4, 2017

Got it yup I remember now.

Is the Dockerhub rigged up now? So I kind of broke things with my new images then?

@YannickB
Copy link
Contributor

YannickB commented Jan 4, 2017

You mean like https://github.com/LasLabs/clouder-cfssl-exec ? To me you're just using it because it's more convenient for you and before we merge it in the main repo.

@lasley
Copy link
Author

lasley commented Jan 4, 2017

Yup exactly, that was the plan I just totally spaced that "main repo" was actually this one and not the clouder images one. Probably still drunk from New Years or something ¯_(ツ)_/¯

Ok so thinking about it, it is possible to use the system I'm making to test nested Dockerfiles - I'm doing it to test itself, so we could just leverage that as part of our overall Clouder testing strategy - https://github.com/LasLabs/docker-quality-tools/blob/release/0.1/tests/test_all

@YannickB
Copy link
Contributor

YannickB commented Jan 4, 2017

Ahah you made my day :)

Great :), looks promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants