-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Add QA and base cmd/entry #1
base: alpine
Are you sure you want to change the base?
Conversation
f91068f
to
03be991
Compare
@@ -1,8 +1,13 @@ | |||
FROM alpine:latest | |||
FROM alpine:3.5 | |||
MAINTAINER Yannick Buron yburon@goclouder.net | |||
|
|||
RUN apk add --update ssmtp wget curl rsync bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lint failing here for using both curl & wget - clouder-community/clouder#194
I will disable the lint here for the time being
56acb3f
to
f10c5f5
Compare
* Add a base docker-entrypoint * Add a base cmd `cat` * Add a Travis file * Add a ReadMe * Fix Lint DL3007 in Dockerfile, stick alpine version
f10c5f5
to
478cd0c
Compare
Hum this repo will not be used anymore because we moved the images in https://github.com/clouder-community/clouder/tree/master/clouder/images/base. No use to update here, do you have a way to make it happen there ? |
We need it to be in its own repo. I thought that every image was in its own repo? How are you pushing to Dockerhub? |
We decided to move them in the main repo, for easier contributions from other developers and also resolve the problem of multi repo which would make the move in the OCA very difficult. I think there is no turning back here. We did it when I realised we can in Dockerhub specify where is located the Dockerfile, then allowing the have several image in same repo. |
Got it yup I remember now. Is the Dockerhub rigged up now? So I kind of broke things with my new images then? |
You mean like https://github.com/LasLabs/clouder-cfssl-exec ? To me you're just using it because it's more convenient for you and before we merge it in the main repo. |
Yup exactly, that was the plan I just totally spaced that "main repo" was actually this one and not the clouder images one. Probably still drunk from New Years or something ¯_(ツ)_/¯ Ok so thinking about it, it is possible to use the system I'm making to test nested Dockerfiles - I'm doing it to test itself, so we could just leverage that as part of our overall Clouder testing strategy - https://github.com/LasLabs/docker-quality-tools/blob/release/0.1/tests/test_all |
Ahah you made my day :) Great :), looks promising. |
Testing of LasLabs/docker-quality-tools#1
cat