Skip to content

Commit

Permalink
refactor: merge collapsible if statements
Browse files Browse the repository at this point in the history
Nested `if` statements can be collapsed into a single `if` statement by separating their condition using `and` operator.
Merging collapsible `if` statements increases the code's readability.
  • Loading branch information
deepsource-autofix[bot] authored Mar 29, 2024
1 parent 31717d6 commit 4603e2c
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions hsf/welcome.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,14 @@ def get_version(url_pattern: str = 'https://pypi.python.org/pypi/HSF/json'):
req = requests.get(url_pattern)
version = parse('0')

if req.encoding:
if req.status_code == requests.codes.ok:
j = json.loads(req.text.encode(req.encoding))
releases = j.get('releases', [])

for release in releases:
ver = parse(release)
if not ver.is_prerelease:
version = max(version, ver)
if req.encoding and req.status_code == requests.codes.ok:
j = json.loads(req.text.encode(req.encoding))
releases = j.get('releases', [])

for release in releases:
ver = parse(release)
if not ver.is_prerelease:
version = max(version, ver)

return version

Expand Down

0 comments on commit 4603e2c

Please sign in to comment.