fix(core): recordCells should not add usableCells

.changeset/gold-bikes-joke.md

@@ -0,0 +1,17 @@
+---
+"@ckb-ccc/core": patch
+"@ckb-ccc/ccc": patch
+"ckb-ccc": patch
+"@ckb-ccc/connector": patch
+"@ckb-ccc/connector-react": patch
+"@ckb-ccc/eip6963": patch
+"@ckb-ccc/joy-id": patch
+"@ckb-ccc/lumos-patches": patch
+"@ckb-ccc/nip07": patch
+"@ckb-ccc/okx": patch
+"@ckb-ccc/rei": patch
+"@ckb-ccc/uni-sat": patch
+"@ckb-ccc/utxo-global": patch
+---
+
+fix(core): recordCells should not add usableCells

packages/core/src/client/cache/memory.ts

@@ -12,9 +12,9 @@ import { ClientCache } from "./cache.js";
 import { filterCell } from "./memory.advanced.js";
 
 export class ClientCacheMemory implements ClientCache {
-  private readonly cachedTransactions: Transaction[] = [];
   private readonly unusableOutPoints: OutPoint[] = [];
   private readonly usableCells: Cell[] = [];
+  private readonly knownTransactions: Transaction[] = [];
   private readonly knownCells: Cell[] = [];
 
   async markUsable(...cellLikes: (CellLike | CellLike[])[]): Promise<void> {
@@ -73,6 +73,18 @@ export class ClientCacheMemory implements ClientCache {
     );
   }
 
+  async *findCells(
+    keyLike: ClientCollectableSearchKeyLike,
+  ): AsyncGenerator<Cell> {
+    for (const cell of this.usableCells) {
+      if (!filterCell(keyLike, cell)) {
+        continue;
+      }
+
+      yield cell;
+    }
+  }
+
   async isUnusable(outPointLike: OutPointLike): Promise<boolean> {
     const outPoint = OutPoint.from(outPointLike);
     return this.unusableOutPoints.find((o) => o.eq(outPoint)) !== undefined;
@@ -81,30 +93,18 @@ export class ClientCacheMemory implements ClientCache {
   async recordTransactions(
     ...transactions: (TransactionLike | TransactionLike[])[]
   ): Promise<void> {
-    this.cachedTransactions.push(...transactions.flat().map(Transaction.from));
+    this.knownTransactions.push(...transactions.flat().map(Transaction.from));
   }
   async getTransaction(txHashLike: HexLike): Promise<Transaction | undefined> {
     const txHash = hexFrom(txHashLike);
-    return this.cachedTransactions.find((tx) => tx.hash() === txHash);
+    return this.knownTransactions.find((tx) => tx.hash() === txHash);
   }
 
   async recordCells(...cells: (CellLike | CellLike[])[]): Promise<void> {
-    this.usableCells.push(...cells.flat().map(Cell.from));
+    this.knownCells.push(...cells.flat().map(Cell.from));
   }
   async getCell(outPointLike: OutPointLike): Promise<Cell | undefined> {
     const outPoint = OutPoint.from(outPointLike);
-    return this.usableCells.find((cell) => cell.outPoint.eq(outPoint));
-  }
-
-  async *findCells(
-    keyLike: ClientCollectableSearchKeyLike,
-  ): AsyncGenerator<Cell> {
-    for (const cell of this.usableCells) {
-      if (!filterCell(keyLike, cell)) {
-        continue;
-      }
-
-      yield cell;
-    }
+    return this.knownCells.find((cell) => cell.outPoint.eq(outPoint));
   }
 }

packages/demo/src/context.tsx

@@ -104,7 +104,7 @@ export function AppProvider({ children }: { children: React.ReactNode }) {
         title,
         msgs.map((msg, i) => (
           <React.Fragment key={i}>
-            {i === 0 ? " " : ""}
+            {i === 0 ? "" : " "}
             {msg}
           </React.Fragment>
         )),