Replace values() with entries() with in enums #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - I was digging into the generated code and I realized there was a recommendation to replace
values()
withentries
when using enums: https://www.jetbrains.com/help/inspectopedia/EnumValuesSoftDeprecate.htmlSince I wanted to contribute back to this library that we started using recently, I figured it was worth a shot. The tests are failing right now because I couldn't figure out how to rebuild the expected models in
src/test/resources/examples
, if you can point me toward the way to do that, I'll finish the work on this pull-request, assuming that's something you'd like.