Introduce --default-image #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition does not provide an image to use
marcusfreisleben
force-pushed
the
feat-default-image
branch
from
6668fb7 to
7bab862
Compare
marcusfreisleben
force-pushed
the
feat-default-image
branch
from
7bab862 to
98d1186
Compare
edigaryev
reviewed
Feb 21, 2025
edigaryev
reviewed
Feb 21, 2025
edigaryev
reviewed
Feb 21, 2025
|
Left a couple of nits, otherwise LGTM 👍 |
edigaryev
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new argument
default-imagefor the prepare stage, replicating the functionality of the docker executor: if noimageis provided by the job definition or viaCI_JOB_IMAGE, fall back to a default image to use.