Fix logic and tests.

chrishalbert · Nov 29, 2016 · c629839 · c629839
1 parent 799376f
commit c629839
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/Input/CloverInput.php b/src/Input/CloverInput.php
@@ -39,7 +39,7 @@ private function seekFileStats(array $files)
     private function seekLineStats(\SimpleXMLElement $file)
     {
         foreach ($file->children()->line as $line) {
-            if (!$line['count']) {
+            if ((int)$line['count']) {
                 continue;
             }
             $lineNumber = (int) $line['num']->__toString();

diff --git a/tests/resources/clover-input.xml b/tests/resources/clover-input.xml
@@ -3,14 +3,14 @@
     <project timestamp="1479006233">
         <package name="package">
             <file name="/home/user/package/subpackage/Foo.php">
-                <line num="1" type="stmt" count="1"/>
+                <line num="1" type="stmt" count="0"/>
                 <line num="2" type="stmt" count="0"/>
                 <line num="3" type="stmt" count="0"/>
             </file>
             <file name="/home/user/package/subpackage/Bar.php">
                 <line num="4" type="stmt" count="0"/>
                 <line num="5" type="stmt" count="0"/>
-                <line num="6" type="stmt" count="0"/>
+                <line num="6" type="stmt" count="1"/>
             </file>
         </package>
     </project>

diff --git a/tests/src/Input/CloverInputTest.php b/tests/src/Input/CloverInputTest.php
@@ -50,10 +50,7 @@ protected function getExpectedEntries()
             ],
             [
                 'file' => '/home/user/package/subpackage/Bar.php', 'line' => 5
-            ],
-            [
-                'file' => '/home/user/package/subpackage/Bar.php', 'line' => 6
-            ],
+            ]
         ];
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,10 +50,7 @@ protected function getExpectedEntries() @@
                 ],
                 [
                     'file' => '/home/user/package/subpackage/Bar.php', 'line' => 5
-                ],
-                [
-                    'file' => '/home/user/package/subpackage/Bar.php', 'line' => 6
-                ],
+                ]
             ];
         }
     }