Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] [WRS-2276] Refactor studio loader config #281

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

alexandraFlavia9
Copy link
Contributor

@alexandraFlavia9 alexandraFlavia9 commented Feb 13, 2025

This PR

Related tickets

Screenshots

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Test Results

185 tests   183 ✅  2m 9s ⏱️
 39 suites    2 💤
  1 files      0 ❌

Results for commit 66fef17.

♻️ This comment has been updated with latest results.

Copy link
Contributor

PR bundle size is 1.005 MB and 52.368 KB more than limit.

Copy link
Contributor

PR bundle size is 1.005 MB and 52.364 KB more than limit.

1 similar comment
Copy link
Contributor

PR bundle size is 1.005 MB and 52.364 KB more than limit.

Copy link
Contributor

PR bundle size is 1.005 MB and 52.364 KB more than limit.

Copy link
Contributor

PR bundle size is 1.005 MB and 52.335 KB more than limit.

Copy link
Contributor

PR bundle size is 1.007 MB and 54.772 KB more than limit.

@alexandraFlavia9 alexandraFlavia9 added the Ready for QA Defines that PR is ready for QA label Feb 19, 2025
Copy link
Contributor

PR bundle size is 1.007 MB and 54.747 KB more than limit.

Copy link
Contributor

PR bundle size is 1.007 MB and 54.747 KB more than limit.

Copy link
Contributor

PR bundle size is 1.007 MB and 54.747 KB more than limit.

Copy link
Contributor

PR bundle size is 1.007 MB and 54.747 KB more than limit.

psamusev
psamusev previously approved these changes Feb 20, 2025
Copy link
Contributor

PR bundle size is 1.011 MB and 59.079 KB more than limit.

@@ -153,7 +153,7 @@ window.StudioUI.studioLoaderConfig({
projectName: projectName,

/* outputTypes: object of all available output types (optional) that have a boolean value */
outputTypes: outputTypes,
outputSettings: outputSettings,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could and should deprecate this, it hasn't any value anymore (output is not possible without output setting)

Copy link
Contributor

PR bundle size is 1.011 MB and 59.079 KB more than limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for QA Defines that PR is ready for QA
Development

Successfully merging this pull request may close these issues.

4 participants