fix test failure for ruby 3 and 3.1 #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skeshari12 <skeshari@msystechnologies.com>
Signed-off-by: skeshari12 <skeshari@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
Signed-off-by: antima-gupta <agupta@msystechnologies.com>
antima-gupta
force-pushed
the
antima/fix_test_failure_for_ruby_3_and_3.1
branch
4 times, most recently
from
7fc7143 to
c9be2ec
Compare
3 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
jaymzh
requested changes
Apr 25, 2023
Comment on lines
+132
to
+133
| # raising exception if time is not a string | ||
| raise TypeError.new("TypeError: Inccorrect Type please pass input value as a String.") unless time_str.is_a? String |
There was a problem hiding this comment.
This is great, but lets do it before the if
There was a problem hiding this comment.
tagging @antima-gupta ~ please review the comments above.
tpowell-progress
added
the
Status: Waiting on Contributor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List