Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookstyle Bot Auto Corrections with Cookstyle 7.30.1 #54

Closed
wants to merge 1 commit into from

Conversation

cookstyle[bot]
Copy link

@cookstyle cookstyle bot commented Jan 17, 2022

This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.

Chef/Style/CommentFormat

Style/RegexpLiteral

Layout/ClosingParenthesisIndentation

  • /attributes/aws.rb:75: Indent ) to column 3 (not 4)

Chef/Modernize/DatabagHelpers

Style/TrailingCommaInHashLiteral

  • /attributes/gce.rb:28: Put a comma after the last item of a multiline hash.

Layout/IndentationWidth

Layout/IndentationStyle

Style/TrailingCommaInArrayLiteral

Chef/Correctness/IncorrectLibraryInjection

Chef/Sharing/InvalidLicenseString

Chef/RedundantCode/LongDescriptionMetadata

Chef/Style/UsePlatformHelpers

Signed-off-by: Cookstyle cookbooks@chef.io

This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.

### Chef/Style/CommentFormat
  - **/Rakefile:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)
  - **/libraries/helpers.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat)

### Style/RegexpLiteral
  - **/attributes/aws.rb:6**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r)

### Layout/ClosingParenthesisIndentation
  - **/attributes/aws.rb:75**: Indent `)` to column 3 (not 4)

### Chef/Modernize/DatabagHelpers
  - **/attributes/azure.rb:18**: Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`. (https://docs.chef.io/workstation/cookstyle/chef_modernize_databaghelpers)

### Style/TrailingCommaInHashLiteral
  - **/attributes/gce.rb:28**: Put a comma after the last item of a multiline hash.

### Layout/IndentationWidth
  - **/libraries/helpers.rb:42**: Use 2 (not 4) spaces for indentation. (https://rubystyle.guide#spaces-indentation)

### Layout/IndentationStyle
  - **/libraries/helpers.rb:44**: Tab detected in indentation. (https://rubystyle.guide#spaces-indentation)

### Style/TrailingCommaInArrayLiteral
  - **/libraries/helpers.rb:44**: Put a comma after the last item of a multiline array. (https://rubystyle.guide#no-trailing-array-commas)
  - **/libraries/helpers.rb:71**: Put a comma after the last item of a multiline array. (https://rubystyle.guide#no-trailing-array-commas)

### Chef/Correctness/IncorrectLibraryInjection
  - **/libraries/helpers.rb:135**: Libraries should be injected into the Chef::DSL::Recipe class and not Chef::Recipe or Chef::Provider classes directly. (https://docs.chef.io/workstation/cookstyle/chef_correctness_incorrectlibraryinjection)
  - **/libraries/helpers.rb:136**: Libraries should be injected into the Chef::DSL::Recipe class and not Chef::Recipe or Chef::Provider classes directly. (https://docs.chef.io/workstation/cookstyle/chef_correctness_incorrectlibraryinjection)

### Chef/Sharing/InvalidLicenseString
  - **/metadata.rb:5**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring)

### Chef/RedundantCode/LongDescriptionMetadata
  - **/metadata.rb:7**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata)

### Chef/Style/UsePlatformHelpers
  - **/recipes/_packer.rb:4**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers)
  - **/recipes/_packer.rb:10**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers)

Signed-off-by: Cookstyle <cookbooks@chef.io>
@cookstyle
Copy link
Author

cookstyle bot commented Jan 26, 2022

Closing this pull request as it has been superseded by #55, which was created with Cookstyle 7.31.1.

@cookstyle cookstyle bot closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants