-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add license check #527
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
5. `@vscode/test-web@0.0.62` | ||
6. `@vscode/vscode-perf@0.0.19` | ||
7. `innosetup@6.0.5` | ||
8. `postcss-nesting@12.0.2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what are the next steps for the Unresolved
dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanNikitenko The file code/.deps/problems.md
just for information. It shows current state. To remove libraries from unresolved dependencies list, we can harvest them using this link harvest or add libraries as exclusions in code/.deps/EXCLUDED/prod.md
or code/.deps/EXCLUDED/dev.md
files.
For example: https://github.com/eclipse-che/che-dashboard/blob/main/.deps/EXCLUDED/dev.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 12 unresolved deps with @vscode
prefix - could you clarify why they are unresolved?
did you try to apply harvest
approach for them?
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64 |
Honestly, I do not have the whole picture of what this PR does. Could we instead of adding all those files, add only one GitHub action, that will be triggered by pushing to the main branch (or pull request)? The action should not block anything and its successful execution may be represented as a badge in the README file. |
@vitaliy-guliy We have some information here che-incubator/dash-licenses: ... docker run --rm -t \
-v ${PWD}/:/workspace/project \
quay.io/che-incubator/dash-licenses:next As a result, this command creates the next files:
Check dependencies docker run --rm -t \
-v ${PWD}/:/workspace/project \
quay.io/che-incubator/dash-licenses:next --check So, this command doesn't create any new files in the project directory (except a temporary one) but checks if the dependencies info is up-to-date and then validates all found dependencies. It returns a non-zero exit code if any of the dependencies are restricted to use. Files Production dependencies
You can click a link with CQ and the next page will be opened |
What does this PR do?
Add license check.
What issues does this PR fix?
fixes eclipse-che/che#23363
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder